feat(project): make project management thread safe #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces uses of Rc and RefCell to Arc and Mutex respectively. This is by far not the best way to achieve thread safety, since acquiring the lock could be done on a per data section basis instead of a per project one. This will be addressed with the rewrite to a CRDT based approach for storing state. This will also remove the countless uses of unwrap().
This will assure that the library is indeed thread safe
maximmaxim345
force-pushed
the
feat/thread-safe-project
branch
from
a7d5549 to
25c1aa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces uses of Rc and RefCell to Arc and Mutex respectively. This is by far not the best way to achieve thread safety, since acquiring the lock could be done on a per data section basis instead of a per project one.
This will be addressed with the rewrite to a CRDT based approach for storing state. This will also remove the countless uses of unwrap().