feat(occara): various improvements and fixes #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autocxx can not mark FFI types as thread safe, therefore this commit manually implements the unsafe Send and Sync traits for all structs. We can do this since OpenCASCADE is thread safe for read only methods. This significantely increases the usability of this library.
This add get_components()/location()/direction() methods for Direction, Direction2D, Axis, Axis2D, PaneAxis and SpaceAxis types.
This commit adds at least a Debug implementation to all types. Debug messages that could be expanded in the future are marked with 'TODO'.
Now the resulting bottle shapes from the OpenCASCADE example and the rust port of it are compared using boolean operations. Due to the complexity, the test is not run by default for now.
maximmaxim345
force-pushed
the
feat/occara-improvements
branch
from
21592d9 to
a65d258
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements various improvements to
occara, as required for #32.This mainly includes:
SendandSynctraits for all typesDebugand where possibleDisplayimplementationsShape::subtract()andShape::intersect()