Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Packetizer/Messsage/Dispatcher #1

Open
maxtaco opened this issue Dec 31, 2014 · 0 comments
Open

Refactor Packetizer/Messsage/Dispatcher #1

maxtaco opened this issue Dec 31, 2014 · 0 comments

Comments

@maxtaco
Copy link
Owner

maxtaco commented Dec 31, 2014

Here's a refactor that I didn't get around to doing:

  • packetizer uses framing byte to io.ReadFull the right amount of data out of the stream. Encapsulates this byte array in the Message object
  • Message object parses itself into a 3- or 4-array
  • Nuke the Transporter.ReadLock and the makeDecodeNext functions, since the data is already in the Message object
  • Change decoding to decode from a buffer inside of the Message object; this is where it gets dicey, since it might be heavyweight to make a new decoder for each message. Might want to "borrow" a local one. Unsure.
jzila pushed a commit to jzila/go-framed-msgpack-rpc that referenced this issue Oct 2, 2015
Separated out external and internal interfaces for Transporter and Dispatcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant