Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap ROV:pending-verification upon verification #25

Open
kevinsbarnard opened this issue Jul 12, 2023 · 4 comments
Open

Remap ROV:pending-verification upon verification #25

kevinsbarnard opened this issue Jul 12, 2023 · 4 comments
Assignees
Labels
core Changes to the application core enhancement New feature or request

Comments

@kevinsbarnard
Copy link
Collaborator

Coordinate with @hohonuuli first.

@kevinsbarnard kevinsbarnard added the enhancement New feature or request label Jul 12, 2023
@kevinsbarnard kevinsbarnard self-assigned this Jul 12, 2023
@hohonuuli
Copy link
Member

Another thought. Instead of putting the verifier in the json, it might be better to just add a verified association to the observation: e.g verified | self | <verifier name>.

@hohonuuli
Copy link
Member

We would, of course, still need to change <platform>:pending-verification to <platform>

@kevinsbarnard
Copy link
Collaborator Author

add a verified association to the observation

The tricky part here is that the verification is tied to the bounding box, of which there may be many for a single observation. I know that in practice, we are almost always doing 1 observation to 1 bounding box association, but that's not always the case (e.g. parts). I guess the question is: what do we want the verification to represent? Just the ID (observation), or also the bounding box coordinates (association)?

@hohonuuli
Copy link
Member

hohonuuli commented Jul 13, 2023

we are almost always doing 1 observation to 1 bounding box association, but that's not always the case (e.g. parts).

My 2 cents is that any non-one-to-one relations should be considered a legacy usage at this point. Going forward we will avoid that.

Parts in VARS have been annotated using a part-of association. So this is would be the canonical usage

nectophore
|- part-of      | Nanomia | nil
`- bounding box | self    | { ... }

I guess the question is: what do we want the verification to represent?

Yeah. That's a discussion to have in the video lab. The simplest (and hence most likely case) is:

  • If there's no bounding box. A verification means the observation has been verified.
  • If there is a bounding box. A verification means both the observation and box are verified.

@kevinsbarnard kevinsbarnard added the core Changes to the application core label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to the application core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants