Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gridview not prompting user to delete corresponding observation after the delete localization button selected #84

Closed
kwalz opened this issue Jan 30, 2025 · 9 comments
Assignees
Labels
core Related to the application core

Comments

@kwalz
Copy link

kwalz commented Jan 30, 2025

See attached where I deleted a localization, it prompted me that I wanted to delete localization but it didn't give me the second prompt to delete corresponding observation ('hanging observation' wording). In vars anno, you can see it left the annotation. We'd like this reinstated, may have been when the SQL change was made this week.
kris

Image Image
@kevinsbarnard
Copy link
Collaborator

Hi @kwalz, I'll test for this soon. One thing to consider: VARS GridView won't give you that prompt if there are other bounding boxes remaining on that observation.

@kevinsbarnard kevinsbarnard self-assigned this Jan 31, 2025
@kevinsbarnard kevinsbarnard added bug core Related to the application core and removed bug labels Jan 31, 2025
@kwalz
Copy link
Author

kwalz commented Jan 31, 2025

Just noting here what I emailed to Kevin last night, this happened for localizations where there were no other localizations on the observation so should have prompted to delete the observation as well (tested on numerous localizations and annotations, only sent screenshot for this one- in screenshots can see observation info).

@kwalz
Copy link
Author

kwalz commented Feb 4, 2025

@kevinsbarnard Was this from the SQL change too?

@kevinsbarnard
Copy link
Collaborator

It likely broken during then too, yes, but indirectly. I'm looking into this right now.

@kevinsbarnard
Copy link
Collaborator

Sorted this out -- with SQL, UUIDs were lowercased, and without, they're uppercased. The difference was causing VARS GridView to trip up when matching the UUIDs to check if the observation was dangling or not. I've added logic so all the UUIDs are normalized now. Pushing out a new version soon.

@kwalz
Copy link
Author

kwalz commented Feb 4, 2025

@kevinsbarnard Would any label and box changes that were made be saved in v0.16? Just wondering if my work was lost. It definitely deleted the localization but with this caps vs not caps were any edits from Gridview saved in VARS db?
kris

@kevinsbarnard
Copy link
Collaborator

Yes, all edits should have been saved normally. As far as I can tell, this only affected the fact that the observation is still dangling in cases where it would have prompted you if you wanted to delete it.

@kwalz
Copy link
Author

kwalz commented Feb 4, 2025

Thanks!

@kevinsbarnard
Copy link
Collaborator

Fixed in v0.16.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to the application core
Projects
None yet
Development

No branches or pull requests

2 participants