-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notice partial gene deletion that spans start codon #24
Comments
In particular, this issue is concerned with solving problem 2 above. We can detect whole gene deletions, but not partial deletions which knock out the start codon - which effectively amount to the same thing. I've seen this issue in both pncA and katG. |
The implementation of this feature will likely need to change when/if iqbal-lab-org/pandora#316 is closed. |
Do you mean that there is a potential fix even without a fix for iqbal-lab-org/pandora#316 ? |
Well noticing failed variants that span the start codon would be a kind of band-aid fix. The proper fix would be the resolution of that pandora issue |
Should we also be detecting when the stop is lost? There are two INH FNs that we miss because we don't detect stop loss and tbprofiler calls stop loss. We have null genotypes spanning the stop codon in both of these samples. |
My guess is yes we should |
I made a change to the partial gene deletion code and also removed the GT CONF filter. The (Illumina) diff I get from these changes is
Most of these FPs are also FPs on tbprofiler also. Regarding the stop lost stuff, Miranda made a good point, maybe we just flag it as an unknown mutation? |
Good idea, flag as unknown seems safest. |
There are two overarching problems drprg has
One way around this could be to notice when we have more than n consecutive VCF entries with a failed/null call and just call resistant? Or, to be more precise, notice when we have a failed position(s) that spans the start codon and then call resistant if it is one of the genes where gene deletion causes resistance.
_Originally posted by @mbhall88 in mbhall88/drprg-paper#2
The text was updated successfully, but these errors were encountered: