Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.4 - Concord::Public generates protected attr_reader methods? #14

Open
tjchambers opened this issue Mar 4, 2017 · 2 comments
Open

Comments

@tjchambers
Copy link
Contributor

I have code:

    include Concord::Public.new(:cycle)

and am testing upgrade to Ruby 2.4.0.

Am receiving a new error:

 protected method `cycle' called for #<OE::ObservationRegenerator:0x007f98c4621ec0>

when I refer to .cycle from another class.

My inference is that I am mistaken and that Concord::Public does NOT create public attr_readers but rather protected attr_readers and that this is just now being detected in latest Ruby 2.4.

@tjchambers
Copy link
Contributor Author

In addition if I add a public

attr_reader :cycle

To same class, my code now works as before.

@mbj
Copy link
Owner

mbj commented Mar 4, 2017

@tjchambers I suspect that there is a behavior change for ruby 2.4. I do not consider 2.4 stable enough yet to switch my clients code to it, as soon this is the case I'll naturally port my ecosystem to it and fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants