Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for aarch64 #219

Closed
mcdope opened this issue Jan 3, 2024 · 0 comments · Fixed by #220
Closed

Add support for aarch64 #219

mcdope opened this issue Jan 3, 2024 · 0 comments · Fixed by #220
Assignees
@mcdope
Labels
enhancement New feature or request
Milestone
0.9.0

Comments

@mcdope
Copy link
Owner

mcdope commented Jan 3, 2024

Turned out I was mistaken. The Makefile doesn't set LIBDIR when compiling for aarch64, so PAM_USB_DEST gets set to "//security" rather than "/lib/lib/aarch64-linux-gnu/security" as it should be. This causes pam_usb.so to be installed to "/security/" where it can't be found by PAM.

I fixed this by adding the following directly after here in the Makefile

ifeq ($(ARCH), aarch64)
	LIBDIR ?= lib/aarch64-linux-gnu
endif

After recompiling the deb and installing, pam_usb works as expected and all files appear to be installed to and referencing the correct directories.

I would make a PR to implement this change but I'm not familiar with Fedora or what its libdir would be on aarch64.

Originally posted by @pogmommy in https://github.com/mcdope/pam_usb/discussions/167#discussioncomment-7428948
@mcdope mcdope added this to the 0.9.0 milestone Jan 3, 2024
mcdope added a commit that referenced this issue Jan 3, 2024
@mcdope
#219: Add support for ARM builds
ef08ab6
@mcdope mcdope self-assigned this Jan 3, 2024
@mcdope mcdope added the enhancement New feature or request label Jan 3, 2024
@mcdope mcdope linked a pull request Jan 3, 2024 that will close this issue
#219: Add support for ARM builds #220
Merged
mcdope added a commit that referenced this issue Jan 4, 2024
@mcdope
#219: Add support for ARM builds (#220)
62e9219 
* #219: Add support for ARM builds

* Also add Amiga support while we are onto it... Amiga forever!

* Fix Makefile stuff for Amiga
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdope mcdope

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

#219: Add support for ARM builds mcdope/pam_usb
1 participant
@mcdope