Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce cardinality of traces/spans for running tests #32

Open
mdelapenya opened this issue May 10, 2022 · 1 comment
Open

Reduce cardinality of traces/spans for running tests #32

mdelapenya opened this issue May 10, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@mdelapenya
Copy link
Owner

We are currently creating a span per test (https://github.com/mdelapenya/junit2otlp/blame/ede48c1865c6a23ce58bf03dfb4fca3c913f0cb5/main.go#L119) and per test suite (https://github.com/mdelapenya/junit2otlp/blame/ede48c1865c6a23ce58bf03dfb4fca3c913f0cb5/main.go#L99) which leads to have different spans per test name and test suite, increasing the cardinality of those spans.

I'd suggest decreasing it naming both spans as run-test and run-suite (or similar) and declaring the test name and test suite name as an attribute of the span.

@v1v @cyrille-leclerc @kuisathaverat wdyt?

@mdelapenya mdelapenya added the enhancement New feature or request label May 10, 2022
@kuisathaverat
Copy link
Collaborator

In the Jenkins OpenTelemetry plugin, we have had the same issue, the problem is that if you move the name of the test to an attribute you will not differentiate them in the UI.

jenkinsci/opentelemetry-plugin#271
jenkinsci/opentelemetry-plugin#260
jenkinsci/opentelemetry-plugin#47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants