New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style-elements 5.0.0 misses function to make unguarded option #157

Open

JDemler opened this issue Aug 30, 2018 · 1 comment

Contributor

JDemler commented Aug 30, 2018

The new style-elements still allows Style.styleSheetWith to be called with a list of options.

The only way to make an option though was Style.unguarded.
This function was commented out, but the code around it stayed the same.
code

Is this an intentional change? How can I achieve unguarded styles in 5.0.0?

The text was updated successfully, but these errors were encountered:

Owner

mdgriffith commented Aug 30, 2018

Unguarded styles became very tricky to implement in 0.19 because toString can't be used in a package or code compiled with --optimize.

So, I removed it when doing the upgrade, but I forgot that it was the only option for styleSheetWith!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment