Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Implement Regular Expression Pattern Modifiers proposal #35285

Closed
2 of 8 tasks
Tracked by #570
Rumyra opened this issue Aug 2, 2024 · 6 comments
Closed
2 of 8 tasks
Tracked by #570

[JS] Implement Regular Expression Pattern Modifiers proposal #35285

Rumyra opened this issue Aug 2, 2024 · 6 comments
Assignees
Labels

Comments

@Rumyra
Copy link
Collaborator

Rumyra commented Aug 2, 2024

Acceptance criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated
  • Interactive example and data repos are updated if appropriate
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes for enabled/preview features
  • Add/remove entry to Firefox experimental features page for preference/released features

Related Gecko bugs

https://bugzilla.mozilla.org/show_bug.cgi?id=1899813

Other

  • Check content open issues to see if any pertain to the subject matter. If there are any that can be closed because of the work, do so. If there are any that can be fixed relatively quickly because of the knowledge from completing this issue and you have time, feel free to go ahead and fix them.
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Aug 2, 2024
@Rumyra Rumyra added Content:JS JavaScript docs Firefox 130 and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Aug 2, 2024
@Rumyra Rumyra moved this from Backlog to Todo in MDN Web Docs Content Team Aug 2, 2024
@Josh-Cena
Copy link
Member

Linking #34863; I made a typo because const pattern = /(?:var|let|const) (?i:foo|bar)\b/i; should be const pattern = /(?:var|let|const) (?i:foo|bar)\b/;, but I was too lazy to follow up for a fix, so that could be part of this work.

@Henderv

This comment was marked as spam.

@dletorey dletorey self-assigned this Aug 6, 2024
@dletorey
Copy link
Contributor

dletorey commented Aug 28, 2024

This is currently not working in Firefox Beta 130 but is working in Firefox Nightly 131.0a1 (2024-08-28)

So possibly rolling over to 131 133 release.

Currently working in Firefox Nightly 131.0a1 (2024-08-28) behind the flag javascript.options.experimental.regexp_modifiers

@dletorey
Copy link
Contributor

Associated PRs

@Josh-Cena
Copy link
Member

#36117

1 similar comment
@Josh-Cena
Copy link
Member

#36117

@github-project-automation github-project-automation bot moved this from In Review to Done in MDN Web Docs Content Team Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants