Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headings not inline with Medium #62

Open
abitdodgy opened this issue Dec 4, 2013 · 3 comments
Open

Headings not inline with Medium #62

abitdodgy opened this issue Dec 4, 2013 · 3 comments

Comments

@abitdodgy
Copy link

Medium's toolbar contains buttons for adding H1 and H2 level headings. But the HTML output is H2 and H3 respectively at the dom level.

Grade.js insets H1 as H2, and so forth...

@mduvall
Copy link
Owner

mduvall commented Dec 5, 2013

This seems fine, what's the issue that you faced with the tags?

@abitdodgy
Copy link
Author

Sorry, I wrote that wrong. Grande.js inserts h1 (from the toolbar) as h1 (into the document), whereas Medium inserts h1 (from the toolbar) as h2 (into the document).

Grande.js' behaviour is not desirable because the h1 heading might be reserved for the document title, which may be entered as a separate field. You don't want a post to have multiple h1s, basically. Medium essentially reserves h1 to the post title...

@mduvall
Copy link
Owner

mduvall commented Dec 5, 2013

No worries, I see your concern - definitely valid that we should only have one technical h1 on the page. Thanks for pointing this one out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants