Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Recommended" libraries that use ESPAsyncTCP might need reviewing #149

Closed
philbowles opened this issue Jul 1, 2020 · 8 comments
Closed
Labels

Comments

@philbowles
Copy link

I have long been a user of ESPAsyncWebserver, ESPAsyncTCP and AsyncTCP and I trust those libraries, as I do all of your work.

I was very disappointed then when I changed all my firmware from PubSubClient to AsyncMqttClient (purely because it was "recommended" by you - an author I trust) because then my nightmare began: all of my firmware instantly broke. AsyncMqttClient is so full of bugs and problems, it is not fit for purpose. It is my own fault for not evaluating it fully - I foolishly assumed that since you named it on your site that it was up to the same standard as your own libraries. Oh boy, was I wrong!

Rather than list all the bugs here with the evidence, I suggest you read this document and after having read it, you may want to reconsider including it on the list of libraries using your excellent offerings, as "People are judged by the company they keep" :)

@kleini
Copy link

kleini commented Jul 1, 2020

Will have a look, whether homieiot/homie-esp8266 can be ported to PangolinMQTT. I encouter some transmission issues with MQTT and need to use fixed versions of ESPAsyncTCP and AsyncMqttClient.

@philbowles
Copy link
Author

@kleini I would be interested in the "fix" to ESPAsyncTCP - Pangolin uses 100% bog-standard version with no problems. I suspect the need for your fixes a probably due to the problems in "The other library".

@kleini
Copy link

kleini commented Jul 1, 2020

#129

@philbowles
Copy link
Author

@kleini OK. Pangolin doesnt have TLS / SSL etc in yet so I won't have spotted that

@kleini
Copy link

kleini commented Jul 1, 2020

No SSL support? That is a big problem especially with MQTT and WiFi as clear text passwords are transferred.

@philbowles
Copy link
Author

@kleini Yes, I appreciate that. Wanted to get it working first. Will be adding TLS very soon

@stale
Copy link

stale bot commented Aug 30, 2020

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 30, 2020
@stale
Copy link

stale bot commented Sep 14, 2020

[STALE_DEL] This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants