Skip to content
This repository has been archived by the owner on Aug 28, 2019. It is now read-only.

Refactor Nettest.OpenReport to be sync #22

Closed
bassosimone opened this issue May 16, 2019 · 0 comments · Fixed by #27
Closed

Refactor Nettest.OpenReport to be sync #22

bassosimone opened this issue May 16, 2019 · 0 comments · Fixed by #27

Comments

@bassosimone
Copy link
Member

Depends on #21
@bassosimone bassosimone changed the title Refactor openReport to be sync Refactor Nettest.OpenReport to be sync May 16, 2019
bassosimone added a commit that referenced this issue May 16, 2019
@bassosimone
nettest.OpenReport: just return an error
46c3700 
Closes #22

In a follow up change, we're going to pass a channel around
for emitting useful warnings.

The failure of trying with a single collector will then be
reported just as a warning.

So we can have a simpler-to-use API.
@bassosimone bassosimone mentioned this issue May 16, 2019
Merged
bassosimone added a commit that referenced this issue May 16, 2019
@bassosimone
nettest.OpenReport: just return an error (#27)
a382823 
Closes #22

In a follow up change, we're going to pass a channel around
for emitting useful warnings.

The failure of trying with a single collector will then be
reported just as a warning.

So we can have a simpler-to-use API.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nettest.OpenReport: just return an error measurement-kit/engine
1 participant
@bassosimone