From 777fd0f534d6faa57c37af38a3278f0c2ba79a60 Mon Sep 17 00:00:00 2001 From: Rudolph Gottesheim Date: Mon, 4 Sep 2023 12:45:04 +0200 Subject: [PATCH 1/2] Make getFirstTrackOrFail work with noUncheckedIndexAccess --- src/camera/core-impl.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/camera/core-impl.ts b/src/camera/core-impl.ts index ad29ec4..fd4e591 100644 --- a/src/camera/core-impl.ts +++ b/src/camera/core-impl.ts @@ -217,12 +217,14 @@ class RenderedCameraImpl implements RenderedCamera { private getFirstTrackOrFail(): MediaStreamTrack { this.failIfClosed(); + + const firstTrack = this.mediaStream.getVideoTracks()[0]; - if (this.mediaStream.getVideoTracks().length === 0) { + if (firstTrack === undefined) { throw "No video tracks found"; } - return this.mediaStream.getVideoTracks()[0]; + return firstTrack; } //#region Public APIs. From 751a5ae59a2ea2c90a2c6face2066ac4e9daded5 Mon Sep 17 00:00:00 2001 From: Rudolph Gottesheim Date: Mon, 4 Sep 2023 13:09:05 +0200 Subject: [PATCH 2/2] Update core-impl.ts --- src/camera/core-impl.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/camera/core-impl.ts b/src/camera/core-impl.ts index fd4e591..7bf3f40 100644 --- a/src/camera/core-impl.ts +++ b/src/camera/core-impl.ts @@ -220,7 +220,7 @@ class RenderedCameraImpl implements RenderedCamera { const firstTrack = this.mediaStream.getVideoTracks()[0]; - if (firstTrack === undefined) { + if (!firstTrack) { throw "No video tracks found"; }