New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin automatically creates undeletable instance upon installation #2

Open

mudrd8mz opened this issue Feb 11, 2021 · 0 comments

mudrd8mz commented Feb 11, 2021

I expect this was well intended as a nice feature. However, I actually consider it a bug.

In the xmldb_block_mmquicklink_install() function, a new instance of the block is created and marked as undeletable.

It is setting the parent context to "1". There is no guarantee that the SYSCONTEXTID is exactly this.
Why is the block added to the undeletableblocktypes ? That setting was supposed to protect essential blocks only such as Navigation or Administration that could not be re-added easily.

Let me suggest to re-consider this whole function.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment