Skip to content

Commit

Permalink
fix: remove camera assertion before sidecar initiation (#1393)
Browse files Browse the repository at this point in the history
* fix: remove camera assertion

* fix: remove camera check from permissions_check

* fix: add accessibility check
  • Loading branch information
oliverqx authored Feb 18, 2025
1 parent e6aa2e6 commit d6c054f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
2 changes: 0 additions & 2 deletions screenpipe-app-tauri/src-tauri/src/permissions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ pub fn do_permissions_check(initial_check: bool) -> OSPermissionsCheck {
}
},
microphone: check_av_permission(AVMediaType::Audio),
camera: check_av_permission(AVMediaType::Video),
accessibility: { check_accessibility_permission() },
}
}
Expand All @@ -152,7 +151,6 @@ pub fn do_permissions_check(initial_check: bool) -> OSPermissionsCheck {
OSPermissionsCheck {
screen_recording: OSPermissionStatus::NotNeeded,
microphone: OSPermissionStatus::NotNeeded,
camera: OSPermissionStatus::NotNeeded,
accessibility: OSPermissionStatus::NotNeeded,
}
}
Expand Down
10 changes: 5 additions & 5 deletions screenpipe-app-tauri/src-tauri/src/sidecar.rs
Original file line number Diff line number Diff line change
Expand Up @@ -520,14 +520,14 @@ impl SidecarManager {
let permissions = do_permissions_check(true);

if permissions.screen_recording != OSPermissionStatus::Granted {
return Err("Screen recording permission denied".to_string());
return Err("Screen recording permission denied".to_string());
}
if permissions.microphone != OSPermissionStatus::Granted {
return Err("Microphone permission denied".to_string());
return Err("Microphone permission denied".to_string());
}
if permission.accessibility != OSPermissionsCheck::Granted {
return Err("Accessibility permission denied".to_string());
}
if permissions.camera != OSPermissionStatus::Granted {
return Err("Camera permission denied".to_string());
}

Ok(())
}
Expand Down

0 comments on commit d6c054f

Please sign in to comment.