-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more dates (eg. <1950) #8
Comments
@alxndrsn would you be able to do that? |
Hi @grzesiek2010, I'll try to get data for extending the supported date range. |
Thanks! |
Fix #9 and once confirmed that our current data agrees with https://github.com/bahadurbaniya/Date-Converter-Bikram-Sambat-to-English-Date, extend using the month-length values from that implementation: no other source of month length data has been found. |
Is that solved? |
@naveagar Not yet. I'm going to try and get to it this week. |
@garethbowen will be very helpful as Nepal is going to implement this widget by 1 Feb, if worked, otherwise, have to use English Cal. Thank you so much in advance. |
This means we can convert a wider range of dates. #8
This means we can convert a wider range of dates. #8
@naveagar @grzesiek2010 I think this is now fixed. I've released v1.1.0 of the jar to the maven repo, and v1.6.0 of the js library and v1.5.0 of the bootstrap plugin to npm. Let me know if you have any issues! |
@garethbowen Thanks a lot. Someone has to now update ODK, so that I can update my app. |
@garethbowen Thanks a lot! I've just created a pr getodk/collect#2814 @naveagar we are going to release v1.19.0 next week so hopefully that pr will be included. |
@garethbowen has this been released to Maven Central, or still in https://staging.dev.medicmobile.org/_couch/maven-repo? |
It's still in staging.dev. It'd be good to move it to maven central some time. |
Any idea, when the v1.19.0 (with Bikram Sambat) will get released? |
@naveagar |
@grzesiek2010 if it could be little then 3-Feb then would be better, as the team will be deployed from 4th Feb and need some time to setup the devices. |
Assuming no major issues are found in the next few days. I'm glad to release end of day on Friday (San Diego time). |
I work as an Android developer on ODK Collect where we use this project.
Recently one of our users wanted to use not supported dates <1950
https://forum.opendatakit.org/t/bikram-sambat-nepali-date-widget/16844
Is it possible to support more dates?
The text was updated successfully, but these errors were encountered: