Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more dates (eg. <1950) #8

Closed
grzesiek2010 opened this issue Dec 21, 2018 · 17 comments
Closed

Support more dates (eg. <1950) #8

grzesiek2010 opened this issue Dec 21, 2018 · 17 comments

Comments

@grzesiek2010
Copy link

grzesiek2010 commented Dec 21, 2018

I work as an Android developer on ODK Collect where we use this project.
Recently one of our users wanted to use not supported dates <1950
https://forum.opendatakit.org/t/bikram-sambat-nepali-date-widget/16844

Is it possible to support more dates?

@grzesiek2010 grzesiek2010 changed the title Support more years (eg. <1950) Support more dates (eg. <1950) Dec 21, 2018
@grzesiek2010
Copy link
Author

@alxndrsn would you be able to do that?

@alxndrsn
Copy link

alxndrsn commented Jan 8, 2019

Hi @grzesiek2010, I'll try to get data for extending the supported date range.

@grzesiek2010
Copy link
Author

I'll try to get data for extending the supported date range.

Thanks!

@alxndrsn
Copy link

Fix #9 and once confirmed that our current data agrees with https://github.com/bahadurbaniya/Date-Converter-Bikram-Sambat-to-English-Date, extend using the month-length values from that implementation: no other source of month length data has been found.

@naveagar
Copy link

Is that solved?

@garethbowen
Copy link
Member

@naveagar Not yet. I'm going to try and get to it this week.

@naveagar
Copy link

@garethbowen will be very helpful as Nepal is going to implement this widget by 1 Feb, if worked, otherwise, have to use English Cal. Thank you so much in advance.

garethbowen added a commit that referenced this issue Jan 23, 2019
This means we can convert a wider range of dates.

#8
garethbowen added a commit that referenced this issue Jan 23, 2019
This means we can convert a wider range of dates.

#8
@garethbowen
Copy link
Member

@naveagar @grzesiek2010 I think this is now fixed. I've released v1.1.0 of the jar to the maven repo, and v1.6.0 of the js library and v1.5.0 of the bootstrap plugin to npm. Let me know if you have any issues!

@naveagar
Copy link

@garethbowen Thanks a lot. Someone has to now update ODK, so that I can update my app.

@grzesiek2010
Copy link
Author

@garethbowen Thanks a lot! I've just created a pr getodk/collect#2814

@naveagar we are going to release v1.19.0 next week so hopefully that pr will be included.

@alxndrsn
Copy link

@garethbowen has this been released to Maven Central, or still in https://staging.dev.medicmobile.org/_couch/maven-repo?

@garethbowen
Copy link
Member

It's still in staging.dev. It'd be good to move it to maven central some time.

@naveagar
Copy link

Any idea, when the v1.19.0 (with Bikram Sambat) will get released?

@grzesiek2010
Copy link
Author

@naveagar
our plan is to release that version on Sunday (February 3rd). Does that work for you?
Here is a not official apk with that fix:
collect-debug-v1.19.0-beta.0-10-gd2683ba.apk.zip
It would be good if you can test it and give feedback.

@naveagar
Copy link

@grzesiek2010
Thanks for providing beta version,I have tested Nepali calendar and it is working fine now. Is this apk has any other update apart from Nepali calendar? I can use this apk also but I wonder if this has been tested for any other changes or not.

if it could be little then 3-Feb then would be better, as the team will be deployed from 4th Feb and need some time to setup the devices.

@grzesiek2010
Copy link
Author

@naveagar
I would rather recommend using the app from the Play Store. @yanokwa what do you think? Maybe we can release on Saturday?

@yanokwa
Copy link

yanokwa commented Jan 31, 2019

Assuming no major issues are found in the next few days. I'm glad to release end of day on Friday (San Diego time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants