From da82291119c716190946fd5ddd7bfbb0a0f620eb Mon Sep 17 00:00:00 2001 From: Sawy Date: Wed, 16 Oct 2024 10:03:59 +0300 Subject: [PATCH] CV2-5348: fix n+1 query --- app/models/bot/smooch.rb | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/app/models/bot/smooch.rb b/app/models/bot/smooch.rb index 733150193..f0d4186af 100644 --- a/app/models/bot/smooch.rb +++ b/app/models/bot/smooch.rb @@ -42,13 +42,12 @@ def report_image def get_deduplicated_tipline_requests uids = [] tipline_requests = [] - ProjectMedia.where(id: self.related_items_ids).each do |pm| - pm.tipline_requests.find_each do |tr| - uid = tr.tipline_user_uid - next if uids.include?(uid) - uids << uid - tipline_requests << tr - end + pm_ids = ProjectMedia.where(id: self.related_items_ids).map(&:id) + TiplineRequest.where(associated_type: 'ProjectMedia', associated_id: pmids).find_each do |tr| + uid = tr.tipline_user_uid + next if uids.include?(uid) + uids << uid + tipline_requests << tr end tipline_requests end