Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] videoroom: support of string_ids/string_ids_user #3364

Open
IgorKhomenko opened this issue Apr 29, 2024 · 2 comments
Open

[1.x] videoroom: support of string_ids/string_ids_user #3364

IgorKhomenko opened this issue Apr 29, 2024 · 2 comments
Labels
enhancement multistream Related to Janus 1.x

Comments

@IgorKhomenko
Copy link

This is more a feature request rather than an issue.

There is a case when integrate Janus with 3rd party system where room id is a string, but user id is a number.

With current version of Janus, it's only possible to have ether string or number for both.

It would be very useful to have a way to configure it separately, e.g. to set string_ids = TRUE; and to have a separate variable for users: string_ids_user = FALSE;
https://github.com/meetecho/janus-gateway/blob/master/src/plugins/janus_videoroom.c#L1951

I already have a custom branch with this change and wondering is it something you are interested in to have, so I could do a PR.

Thank you in advance

@IgorKhomenko IgorKhomenko added the multistream Related to Janus 1.x label Apr 29, 2024
@amnonbb
Copy link
Contributor

amnonbb commented May 1, 2024

In our case we need change for users string but leave rooms with number. Is it possible in your branch?

@IgorKhomenko
Copy link
Author

@amnonbb here is a PR #3369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement multistream Related to Janus 1.x
Projects
None yet
Development

No branches or pull requests

3 participants