Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

«--notemp» does not recreate «new directory created in the current directory» but unpack all files to old directory with same name #300

Open
belonesox opened this issue Mar 31, 2023 · 5 comments

Comments

@belonesox
Copy link
Contributor

belonesox commented Mar 31, 2023

On documentation we see

«
--notemp : The generated archive will not extract the files to a temporary directory, but in a new directory created in the current directory. This is better to distribute software packages that may extract and compile by themselves (i.e. launch the compilation through the embedded script).
»

Consider that directory named «out».
If the directory named out already exists, we expect that if the --nooverwrite tag is not used, the old out directory will be deleted and the content will be unpacked to a new, clean out directory.

What we have now («makeself-2.4.5») is that makeself unpacks content to the subdirectory out, overwriting existing files, but keeping old files (which may remain from previous installations, for example), thus tainting the installation process.

We're not sure if this is a bug or a feature, but we don't see a way to get a clean out directory while unpacking. The --cleanup option is available, but it's not reliable and doesn't guarantee that the out directory will always be clean or absent.

@realtime-neil
Copy link
Contributor

Consider that directory named «out».
If the directory named out already exists, we expect that if the --nooverwrite tag is used, the old out directory will be deleted and the content will be unpacked to a new, clean out directory.

This exactly and diametrically opposite to how I assume --nooverwrite should behave.

@belonesox
Copy link
Contributor Author

Consider that directory named «out».
If the directory named out already exists, we expect that if the --nooverwrite tag is used, the old out directory will be deleted and the content will be unpacked to a new, clean out directory.

This exactly and diametrically opposite to how I assume --nooverwrite should behave.

Sorry, I missed, I mean "… we expect that if the --nooverwrite tag is not used … "

@realtime-neil
Copy link
Contributor

Ah. That makes more sense. How about something like this?

#301

@belonesox
Copy link
Contributor Author

Wow! Exactly that! Thank you for quick fix!

@realtime-neil
Copy link
Contributor

Happy to help! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants