Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconstructions default to input datasets scale #465

Open
edyoshikun opened this issue Jan 8, 2024 · 2 comments
Open

reconstructions default to input datasets scale #465

edyoshikun opened this issue Jan 8, 2024 · 2 comments

Comments

@edyoshikun
Copy link
Contributor

The output dataset's scale is wrong as it is read from the input here

Should the zyx scale be taken from the config file instead? Specifically, in the case of falcon datasets, the bug arises from here.

@edyoshikun edyoshikun added bug Something isn't working and removed bug Something isn't working labels Jan 8, 2024
@edyoshikun
Copy link
Contributor Author

The easier fix is to update-scale-metadata before starting any processing.

@talonchandler
Copy link
Collaborator

Closely related to #457.

Our plan is to use the input dataset's scale metadata by default, and use the config file's metadata to override the input's scale metadata.

@edyoshikun will that design work for your use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants