Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMPATH Form Translations should take into account the form version. #244

Open
ibacher opened this issue May 30, 2023 · 7 comments
Open

AMPATH Form Translations should take into account the form version. #244

ibacher opened this issue May 30, 2023 · 7 comments

Comments

@ibacher
Copy link
Member

ibacher commented May 30, 2023

No description provided.

@mks-d
Copy link
Member

mks-d commented Jun 28, 2024

@ibacher is this still current or we can close this issue?

@ibacher
Copy link
Member Author

ibacher commented Jun 28, 2024

This one still needs to be done. Specifically, when loading a new version of an AMPATH Form, we need to reload the translations for that form so we end up with the form resources attached to the new form.

@mks-d mks-d changed the title AMPATH Form Translations should take into account form version AMPATH Form Translations should take into account the form version. Jun 28, 2024
@mks-d
Copy link
Member

mks-d commented Jun 28, 2024

@ibacher I'm wondering why this was not needed more in our implementation(s), could you speak to it @Ruhanga?

If we could live without it until now, and that the React Form Engine supersedes the AMPATH Form Engine, then this issue may be closed no?

@ibacher
Copy link
Member Author

ibacher commented Jun 28, 2024

There are two things that make this a little rare to come across:

  1. Most implementations are mono-lingual and so, as long as the form works in the target language (usually English) translations aren't needed.
  2. The issue only arises when you have a form available in multiple languages and release a new version of the form, but with no additional translation keys needed, e.g., because you added a question that just uses the concept string.

Basically, AFAIK, the only implementation to run up against this is the ICRC, but other non-English implementations are likely to run into this.

@mks-d
Copy link
Member

mks-d commented Jun 29, 2024

the only implementation to run up against this is the ICRC

In that case it would be good for @icrc-fdeniger to read through this and let us know if this issue should remain open.

@icrc-fdeniger
Copy link
Contributor

icrc-fdeniger commented Jul 1, 2024

I would say yes as it's not specific to ICRC but to non mono-ligual implementations.

@Ruhanga
Copy link
Member

Ruhanga commented Jul 2, 2024

This issue is duplicated by this other one.

I'm wondering why this was not needed more in our implementation(s), could you speak to it @Ruhanga?

@mks-d we re-discovered it when working with the Cambodia distro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants