Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SORTEE Peer code review #1

Closed
DrMattG opened this issue Nov 10, 2021 · 0 comments
Closed

SORTEE Peer code review #1

DrMattG opened this issue Nov 10, 2021 · 0 comments

Comments

@DrMattG
Copy link

DrMattG commented Nov 10, 2021

[https://github.com/SORTEE/peer-code-review/issues/8]

Hi, I thought I'd start to look at the code before the code review. Some quick comments below:

  • The code runs and does what I expected it to do!
  • The .Rmd for 01 seems to be missing
  • It might be good to consider adding some folder structure to "clean up" the repo a bit - you could put all the rmd files in one folder called "scripts" to help users navigate to them for example
  • It might be worth considering using renv to make sure that the libraries needed are loaded and are the correct version to rerun the analysis in 2 or 5 years time. It will also help the user to ensure they all have the right packages installed before they try and run the code
@DrMattG DrMattG closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant