Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add databases support #21

Open
melizeche opened this issue Oct 17, 2019 · 2 comments
Open

Add databases support #21

melizeche opened this issue Oct 17, 2019 · 2 comments

Comments

@melizeche
Copy link
Owner

melizeche commented Oct 17, 2019

Feature Request

Summary

Add database support, right now there's no historic data about the exchange rate

Basic example

Could be any SQL database but probably the best idea would be to use some ORM to support many databases at once, suggestions are welcome

Motivation

To eventually build graphs about the exchange rate evolution

@goodgodth
Copy link

I send PR already in #35 , let check it out

@fermellone
Copy link
Contributor

  1. I plan to use SQLModel as ORM, with PostgreSQL and SQLite as the base.
  2. To create a decorator that stores the scrapped data within each defined database based on a schedule. (I thought on a daily schedule, but @melizeche mentioned it should be every 10 minutes.)
  3. To implement the decorator to each scrapper function at coti.py.

Which fields should the "exchange_rates" table have?
Are there other tables that we should consider?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants