From 20d81074bcda8465fabf5889d6f208288412a617 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edgar=20Ram=C3=ADrez=20Mondrag=C3=B3n?= <16805946+edgarrmondragon@users.noreply.github.com> Date: Mon, 26 Feb 2024 18:32:30 -0600 Subject: [PATCH] Fix `sensitive` to be boolean --- hub_utils/meltano_util.py | 2 +- tests/test_meltano_utils.py | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hub_utils/meltano_util.py b/hub_utils/meltano_util.py index 1d72b6f..fab2328 100644 --- a/hub_utils/meltano_util.py +++ b/hub_utils/meltano_util.py @@ -299,7 +299,7 @@ def _parse_sdk_about_settings(sdk_about_dict, enforce_desc=False): if kind != "date_iso8601": setting_details["value"] = settings.get("default") if kind == "password": - setting_details["sensitive"] = "true" + setting_details["sensitive"] = True reformatted_settings.append(setting_details) if settings.get("required"): settings_group_validation.append(settings.get("name")) diff --git a/tests/test_meltano_utils.py b/tests/test_meltano_utils.py index 5d2039b..f49172a 100644 --- a/tests/test_meltano_utils.py +++ b/tests/test_meltano_utils.py @@ -19,14 +19,14 @@ def test_sdk_about_parsing_1(): "label": "Client ID", "description": "", "kind": "password", - "sensitive": "true", + "sensitive": True, }, { "name": "client_secret", "label": "Client Secret", "description": "", "kind": "password", - "sensitive": "true", + "sensitive": True, }, { "name": "start_date", @@ -66,7 +66,7 @@ def test_sdk_about_parsing_2(): "label": "Federation Auth Password", "description": "The HTTP basic auth password to authenticate against the meshObject API for federation", "kind": "password", - "sensitive": "true", + "sensitive": True, }, { "name": "federation.api_url", @@ -195,28 +195,28 @@ def test_sdk_about_parsing_airbyte(): "label": "Connector Config Provider Bucket", "description": "Name of the S3 bucket where the file(s) exist.", "kind": "password", - "sensitive": "true", + "sensitive": True, }, { "name": "connector_config.provider.aws_access_key_id", "label": "Connector Config Provider AWS Access Key ID", "description": "In order to access private Buckets stored on AWS S3, this connector requires credentials with the proper permissions. If accessing publicly available data, this field is not necessary.", "kind": "password", - "sensitive": "true", + "sensitive": True, }, { "name": "connector_config.provider.aws_secret_access_key", "label": "Connector Config Provider AWS Secret Access Key", "description": "In order to access private Buckets stored on AWS S3, this connector requires credentials with the proper permissions. If accessing publicly available data, this field is not necessary.", "kind": "password", - "sensitive": "true", + "sensitive": True, }, { "name": "connector_config.provider.path_prefix", "label": "Connector Config Provider Path Prefix", "description": "By providing a path-like prefix (e.g. myFolder/thisTable/) under which all the relevant files sit, we can optimize finding these in S3. This is optional but recommended if your bucket contains many folders/files which you don't need to replicate.", "kind": "password", - "sensitive": "true", + "sensitive": True, "value": "" }, { @@ -224,7 +224,7 @@ def test_sdk_about_parsing_airbyte(): "label": "Connector Config Provider Endpoint", "description": "Endpoint to an S3 compatible service. Leave empty to use AWS.", "kind": "password", - "sensitive": "true", + "sensitive": True, "value": "" }, {