Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the modules with Terraform 0.15 can fail due to use of 'sensitive' output in metadata #121

Open
4 of 7 tasks
memes opened this issue Apr 23, 2021 · 0 comments
Open
4 of 7 tasks
Assignees
Labels
bug Something isn't working
Milestone

Comments

@memes
Copy link
Owner

memes commented Apr 23, 2021

Describe the bug

Terraform 0.15 fails to deploy BIG-IP from these modules due to interpretation of metadata output as containing sensitive information. Fix will be to explicitly mark metadata map output from metadata sub-module as sensitive, even though it does not contain sensitive information.

Terraform modules used

  • BIG-IP standalone
  • BIG-IP HA
  • BIG-IP CFE

GCP environment

  • Standalone project (default)
  • Shared VPC Host project
  • Shared VPC Service project
  • Integration with serverless (Cloud Functions, Cloud Run, App Engine, etc.)

Any other details we need to know?

Reproducing the issue

Deploy BIG-IP from this module.

Additional context

❯ terraform -version                                                                                                                  
Terraform v0.15.0
on darwin_amd64
+ provider registry.terraform.io/hashicorp/google v3.58.0
+ provider registry.terraform.io/hashicorp/google-beta v3.58.0
+ provider registry.terraform.io/hashicorp/random v3.1.0
+ provider registry.terraform.io/hashicorp/template v2.2.0
+ provider registry.terraform.io/hashicorp/time v0.7.0
+ provider registry.terraform.io/hashicorp/tls v3.1.0

❯ terraform providers                                                                                  

Providers required by configuration:
.
├── provider[registry.terraform.io/hashicorp/google] ~> 3.58
├── provider[registry.terraform.io/hashicorp/tls]
├── provider[registry.terraform.io/hashicorp/time]
├── provider[terraform.io/builtin/terraform]
├── module.bigip
│   ├── provider[registry.terraform.io/hashicorp/google] >= 3.48.0
│   ├── module.metadata
│   └── module.do_payloads
├── module.bastions
│   └── provider[registry.terraform.io/hashicorp/google]
├── module.bigip_admin_password
│   ├── provider[registry.terraform.io/hashicorp/google] ~> 3.44
│   ├── provider[registry.terraform.io/hashicorp/random]
│   └── module.secret
│       └── provider[registry.terraform.io/hashicorp/google] ~> 3.44
├── module.gamma
│   ├── provider[registry.terraform.io/hashicorp/google] >= 2.12.0, < 4.0.0
│   ├── module.vpc
│       ├── provider[registry.terraform.io/hashicorp/google] ~> 3.45
│       └── provider[registry.terraform.io/hashicorp/google-beta] ~> 3.45
│   ├── module.firewall_rules
│       └── provider[registry.terraform.io/hashicorp/google] >= 2.12.0, < 4.0.0
│   ├── module.routes
│       └── provider[registry.terraform.io/hashicorp/google] >= 2.12.0, < 4.0.0
│   └── module.subnets
│       └── provider[registry.terraform.io/hashicorp/google] >= 2.12.0, < 4.0.0
├── module.alpha
│   ├── provider[registry.terraform.io/hashicorp/google] >= 2.12.0, < 4.0.0
│   ├── module.vpc
│       ├── provider[registry.terraform.io/hashicorp/google-beta] ~> 3.45
│       └── provider[registry.terraform.io/hashicorp/google] ~> 3.45
│   ├── module.firewall_rules
│       └── provider[registry.terraform.io/hashicorp/google] >= 2.12.0, < 4.0.0
│   ├── module.routes
│       └── provider[registry.terraform.io/hashicorp/google] >= 2.12.0, < 4.0.0
│   └── module.subnets
│       └── provider[registry.terraform.io/hashicorp/google] >= 2.12.0, < 4.0.0
├── module.oslo_dns
│   ├── provider[registry.terraform.io/hashicorp/google-beta]
│   └── provider[registry.terraform.io/hashicorp/google]
├── module.gcp_tcp
│   └── provider[registry.terraform.io/hashicorp/google]
├── module.oslo_tls_key
│   └── provider[registry.terraform.io/hashicorp/google] ~> 3.44
├── module.oslo_auth_token
│   ├── provider[registry.terraform.io/hashicorp/google] ~> 3.44
│   ├── provider[registry.terraform.io/hashicorp/random]
│   └── module.secret
│       └── provider[registry.terraform.io/hashicorp/google] ~> 3.44
├── module.control-router
│   └── provider[registry.terraform.io/hashicorp/google]
├── module.gcp_http_proxy_neg
│   └── provider[registry.terraform.io/hashicorp/google]
├── module.beta
│   ├── provider[registry.terraform.io/hashicorp/google] >= 2.12.0, < 4.0.0
│   ├── module.subnets
│       └── provider[registry.terraform.io/hashicorp/google] >= 2.12.0, < 4.0.0
│   ├── module.vpc
│       ├── provider[registry.terraform.io/hashicorp/google] ~> 3.45
│       └── provider[registry.terraform.io/hashicorp/google-beta] ~> 3.45
│   ├── module.firewall_rules
│       └── provider[registry.terraform.io/hashicorp/google] >= 2.12.0, < 4.0.0
│   └── module.routes
│       └── provider[registry.terraform.io/hashicorp/google] >= 2.12.0, < 4.0.0
├── module.sa
│   ├── provider[registry.terraform.io/hashicorp/template]
│   └── provider[registry.terraform.io/hashicorp/google] ~> 3.53
├── module.gcp_http_proxy
│   └── provider[registry.terraform.io/hashicorp/google]
├── module.alpha_proxy_subnet
│   └── provider[registry.terraform.io/hashicorp/google-beta] >= 2.19.0, < 4.0.0
├── module.servers
│   └── provider[registry.terraform.io/hashicorp/google]
└── module.clients
    └── provider[registry.terraform.io/hashicorp/google]

DO NOT UPLOAD OR LINK TO FILES WITH SENSITIVE INFORMATION, SERVICE ACCOUNT KEYS, ETC.

@memes memes added the bug Something isn't working label Apr 23, 2021
@memes memes added this to the 2.1.1 milestone Apr 23, 2021
@memes memes self-assigned this Apr 23, 2021
memes added a commit that referenced this issue Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant