From b6ba881ee96297972682e8cee03751b9bb46445c Mon Sep 17 00:00:00 2001 From: Manuel Zedel Date: Thu, 9 Jan 2025 13:37:18 +0100 Subject: [PATCH 1/2] ci(gui): always keep video recordings of e2e runs on release related branches - to ease checking OS setup functionality Signed-off-by: Manuel Zedel --- frontend/tests/e2e_tests/docker-compose.e2e-tests.yml | 3 ++- frontend/tests/e2e_tests/playwright.config.ts | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/frontend/tests/e2e_tests/docker-compose.e2e-tests.yml b/frontend/tests/e2e_tests/docker-compose.e2e-tests.yml index f59b02c1..173e6a10 100644 --- a/frontend/tests/e2e_tests/docker-compose.e2e-tests.yml +++ b/frontend/tests/e2e_tests/docker-compose.e2e-tests.yml @@ -22,8 +22,9 @@ services: deploy: replicas: 0 environment: - - TEST_ENVIRONMENT + - CI_COMMIT_REF_PROTECTED - NODE_TLS_REJECT_UNAUTHORIZED=0 + - TEST_ENVIRONMENT networks: - default depends_on: diff --git a/frontend/tests/e2e_tests/playwright.config.ts b/frontend/tests/e2e_tests/playwright.config.ts index 61bfddd6..fa77fdef 100644 --- a/frontend/tests/e2e_tests/playwright.config.ts +++ b/frontend/tests/e2e_tests/playwright.config.ts @@ -69,7 +69,7 @@ const options: PlaywrightTestConfig = { ...contextArgs, contextOptions: contextArgs, screenshot: 'only-on-failure', - video: 'retain-on-failure', + video: process.env.CI_COMMIT_REF_PROTECTED ? 'on' : 'retain-on-failure', // headless: false, launchOptions, trace: process.env.BROWSER == 'webkit' ? 'retain-on-failure' : 'off' From d2f6dcd2f3aa682c8c77da38304169a07db4a740 Mon Sep 17 00:00:00 2001 From: Manuel Zedel Date: Thu, 9 Jan 2025 14:09:56 +0100 Subject: [PATCH 2/2] chore: debug Signed-off-by: Manuel Zedel --- frontend/tests/e2e_tests/playwright.config.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/frontend/tests/e2e_tests/playwright.config.ts b/frontend/tests/e2e_tests/playwright.config.ts index fa77fdef..2719a6ff 100644 --- a/frontend/tests/e2e_tests/playwright.config.ts +++ b/frontend/tests/e2e_tests/playwright.config.ts @@ -68,11 +68,11 @@ const options: PlaywrightTestConfig = { use: { ...contextArgs, contextOptions: contextArgs, - screenshot: 'only-on-failure', - video: process.env.CI_COMMIT_REF_PROTECTED ? 'on' : 'retain-on-failure', // headless: false, launchOptions, - trace: process.env.BROWSER == 'webkit' ? 'retain-on-failure' : 'off' + screenshot: 'only-on-failure', + trace: process.env.BROWSER == 'webkit' ? 'retain-on-failure' : 'off', + video: process.env.CI_COMMIT_REF_PROTECTED ? 'on' : 'retain-on-failure' } };