Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove watchOptions prop #33

Open
WofWca opened this issue Feb 28, 2020 · 5 comments
Open

Remove watchOptions prop #33

WofWca opened this issue Feb 28, 2020 · 5 comments

Comments

@WofWca
Copy link

WofWca commented Feb 28, 2020

And just always watch options instead.

  1. The API is unintuitive, and unnecessary. Users can just create a non-reactive options object by themselves.
  2. This prop also almost doubles the size of the package (if we don't count perfect-scrollbar itself
@mercs600
Copy link
Owner

Hi, thank you for proposition. I'm wondering what gives you reactive options when you have to reinitialize perfect scrollbar instance again ? PS instance is not reactive itself, so I have to destroy and create new one. What do you think ?

@WofWca
Copy link
Author

WofWca commented Feb 28, 2020

I'm wondering what gives you reactive options when you have to reinitialize perfect scrollbar instance again ?

Sorry, could you rephrase?

@mercs600
Copy link
Owner

Ok never mind, I did not understand you the first time -) So you want it to watch options by default ?

@WofWca
Copy link
Author

WofWca commented Feb 28, 2020

Yes.

@mercs600
Copy link
Owner

I will take into account, because it will be breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants