You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug #12654 replaced target_system = self.environment.machines.target.system with target_system = self.environment.machines.host.system which completely breaks the logic from #10616
I think target shouldn't be replaced with host in the whole mesonbuild/backend/vs2010backend.py, because you should be able to generate and build Visual Studio solutions on hosts that don't match the target machine (for example building arm64 projects on x64 host).
The text was updated successfully, but these errors were encountered:
Just to make sure the terminology is straight:
Build is the machine running meson
Host is the machine that the compiled binaries will run on
Target is the machine that compiled binaries will produce binaries for
Ok, it's a bit confusing, so I was wrong about the other hosts (they should work). Then the compatibility with mentioned PR #10616 is broken. Previously Gaming.Desktop.x64 from [target_machine] was placed in solution as self.platform. It relies on MSVC GDK extension, which recognizes Gaming.Desktop.x64 and adds required dependencies to toolchain. Right now it assigns the default host which is the same as build - x64 - which means MSVC will try to build the usual Windows build. If I change [target_machine] to [host_machine] in cross file, I have to manually specify parameters in [binaries] which previously worked with defaults.
Describe the bug
#12654 replaced
target_system = self.environment.machines.target.system
withtarget_system = self.environment.machines.host.system
which completely breaks the logic from #10616I think
target
shouldn't be replaced withhost
in the wholemesonbuild/backend/vs2010backend.py
, because you should be able to generate and build Visual Studio solutions on hosts that don't match the target machine (for example building arm64 projects on x64 host).The text was updated successfully, but these errors were encountered: