Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JSQLParser to 5.0 #91

Open
crisptrutski opened this issue Aug 22, 2024 · 2 comments
Open

Upgrade JSQLParser to 5.0 #91

crisptrutski opened this issue Aug 22, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@crisptrutski
Copy link
Contributor

We're currently on 4.9

https://search.maven.org/artifact/com.github.jsqlparser/jsqlparser

@crisptrutski crisptrutski added the good first issue Good for newcomers label Aug 22, 2024
@crisptrutski
Copy link
Contributor Author

As part of the upgrade we should look into what new flags should be utilized, seeing if we can remove the "implicit semicolon" hack code for analysis (we'll still need it for find-replace). We'll also need to consider what it does to memory usage.

@crisptrutski
Copy link
Contributor Author

It also seems like there are some breaking changes on the visitor interface

Unhandled java.lang.AbstractMethodError
   Receiver class com.metabase.macaw.AstWalker does not define or inherit an
   implementation of the resolved method 'abstract java.lang.Object
   visit(net.sf.jsqlparser.statement.select.Select, java.lang.Object)' of
   interface net.sf.jsqlparser.statement.StatementVisitor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant