-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contributing.md to these metafacture repos #391
Comments
Are there any plans to integrate metafacture-fix and metafacture-flux into metafacture-core? (See also metafacture/metafacture-flux#13) |
I think maybe for metafacture-blog it would be better to have an own CONTRIBUTING.md. If I read as example the "how do I submit a bugreport"-section in the metafacture-core CONTRIBUTING.md, parts like
I think we already discussed that if a repo has an own CONTRIBUTING.md we don't need a link to the metafacture-core CONTRIBUTING.md. Do you miss something in the metafacture-playground CONTRIBUTING.md which is in the metafacture-core CONTRIBUTING.md? If yes, we can open a ticket in metafacture-playground and add these parts to the metafacture-playground CONTRIBUTING.md. |
Re. metafacture-blog, we could a dd a rather short CONTRIBUTING.md which documents how to create a PR with a new blog post. Thus, community members could quite easily write about their experiences with Metafacture. From my point of view we could also leave a CONTRIBUTING.md for metafacture-blog out for now. |
No current plans. Long term, if our Xtext / language server protocol (LSP) approach for Fix tooling (in VS code/codium extension and Playground) works out, it might make more sense to move the Flux implementation out of metafacture-core and into metafacture-flux. If the LSP approach doesn't work out, it might make sense to move metafacture-fix into metafacture-core (with a plain ANTLR implementation). |
+1 for:
|
+1 |
Pointing to metafacture-core's CONTRIBUTING.md as discussed in metafacture/metafacture-core#391.
Pointing to metafacture-core's CONTRIBUTING.md as discussed in metafacture/metafacture-core#391.
Opened metafacture/metafacture-flux#14. |
We identified two repos and referenced their CONTRIBUTING.md to the one here. |
We elaborated a comprehensive CONTRUBUTING.md and thought about providing it to some other metafacture-repos where this would make sense:
- [ ] https://github.com/metafacture/metafacture-blog(will have an CONTRIBUTING.md on its own)- [ ] https://github.com/metafacture/metafacture-playgroundWe would add a
CONTRIBUTING.md
to these repos consisting of just a link pointing to the one residing here.Conflicts:
a) in metafacture-playground there is already a
CONTRIBUTING.md
.b) Also, it seems to me that at least the last part of this repo's
CONTRIBUTING.md
"Releasing Metafacture" should then be somehow capsulated or made be more generic so that it could be applied to all there repos.The text was updated successfully, but these errors were encountered: