Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight signature of flux-commands #16

Open
TobiasNx opened this issue May 10, 2022 · 7 comments
Open

Highlight signature of flux-commands #16

TobiasNx opened this issue May 10, 2022 · 7 comments
Assignees

Comments

@TobiasNx
Copy link
Collaborator

TobiasNx commented May 10, 2022

The signature is the central info when constructing an FLUX workflow it shows which input is needed and what output is created by an modul. This gives orientation which modul can be combined.
It should be highlighted so one can combiner flux moduls more easily.

change-id
---------
- description:	By default changes the record ID to the value of the '_id' literal (if present). Use the contructor to choose another literal as ID source.
- options:	keepidliteral (boolean), idliteral (String), keeprecordswithoutidliteral (boolean)
- signature:	StreamReceiver -> StreamReceiver
- java class:	org.metafacture.mangling.RecordIdChanger

@TobiasNx
Copy link
Collaborator Author

Ideas:

  • sort all moduls by input
  • split singnature to in and out
  • work with color highlighting
  • set as first attribute

@dr0i
Copy link
Member

dr0i commented Nov 27, 2023

I don't understand the ideas - an example would be good.

@TobiasNx
Copy link
Collaborator Author

The idea was something like this: but I am not sure anymore.

change-id
---------
- description:	By default changes the record ID to the value of the '_id' literal (if present). Use the contructor to choose another literal as ID source.
- options:	keepidliteral (boolean), idliteral (String), keeprecordswithoutidliteral (boolean)
- in:	StreamReceiver
- out: StreamReceiver
- java class:	org.metafacture.mangling.RecordIdChanger

perhaps::

- signature: in: StreamReceiver -> out: StreamReceiver

would be enough, that would help when searching the documentation.

@dr0i what do you think?

@dr0i
Copy link
Member

dr0i commented Oct 7, 2024

  • signature: in: StreamReceiver -> out: StreamReceiver

I don't like that, structurally, because of the different meanings of : which are not self evident.
I also think - signature: StreamReceiver -> StreamReceiver is fine enough.

It seems you struggle with the semantics of signature. So maybe we just find a more self-describing word/phrase, like:

- Input/Output: StreamReceiver -> StreamReceiver

@dr0i dr0i assigned TobiasNx and unassigned dr0i Oct 7, 2024
@TobiasNx
Copy link
Collaborator Author

TobiasNx commented Oct 9, 2024

  • signature: in: StreamReceiver -> out: StreamReceiver

I don't like that, structurally, because of the different meanings of : which are not self evident. I also think - signature: StreamReceiver -> StreamReceiver is fine enough.

It seems you struggle with the semantics of signature. So maybe we just find a more self-describing word/phrase, like:

- Input/Output: StreamReceiver -> StreamReceiver

My main intention is to improve searchability.

@blackwinter
Copy link
Member

Well, you can utilise the current syntax to search specifically for inputs (: StreamReceiver) and outputs (> StreamReceiver).

@dr0i
Copy link
Member

dr0i commented Oct 10, 2024

Well, you can utilise the current syntax to search specifically for inputs (: StreamReceiver) and outputs (> StreamReceiver).

That's what I do, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants