Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release metafacture-fix 1.2.0 based on core 6.2.0 #390

Closed
dr0i opened this issue Dec 16, 2024 · 19 comments
Closed

Release metafacture-fix 1.2.0 based on core 6.2.0 #390

dr0i opened this issue Dec 16, 2024 · 19 comments
Assignees

Comments

@dr0i
Copy link
Member

dr0i commented Dec 16, 2024

Like #361.
Depends partly on metafacture/metafacture-core#580.

See how-to in the wiki.

@dr0i
Copy link
Member Author

dr0i commented Dec 19, 2024

Based on the master (plus the newest metafacture-core release) the github packages release 1.2.0-rc1 is ready . Please test it and check mark:

@blackwinter
Copy link
Member

Thanks! Should we maybe add some kind of a "notice of discontinuance" to the release notes? Something along the following lines:

This is the final release of metafacture-fix as a standalone project. All future versions will be included in metafacture-core releases.

@dr0i
Copy link
Member Author

dr0i commented Dec 19, 2024

Shall we include this notice also as commit message ?

@blackwinter
Copy link
Member

Yes, it is planned that we update the README before archiving the repository.

@dr0i
Copy link
Member Author

dr0i commented Dec 19, 2024

Ah, good - as this is planned I won't put it into the commit message of this release. Or should we do this for now and have the notice as part of the release?

@blackwinter
Copy link
Member

No, I don't think we should do it before the merger is completed.

@dr0i
Copy link
Member Author

dr0i commented Dec 19, 2024

I couldn't deploy the 1.2.0-rc1 via docker. @Phu2 could you give it a try?

@dr0i
Copy link
Member Author

dr0i commented Dec 19, 2024

After @Phu2 has deployed the rc branch to test.metafacture.org/playground and @TobiasNx has testes that instance @fsteeg could go on with the release as descibed in this ticket.

@dr0i dr0i assigned fsteeg, Phu2 and TobiasNx and unassigned dr0i Dec 19, 2024
@dr0i dr0i moved this from Selected to Ready in Metafacture Dec 19, 2024
@Phu2
Copy link

Phu2 commented Dec 19, 2024

I tried to build the Docker image anew without any build cache and ran into an error during RUN ./gradlew install.

Excerpt:

62.86 > Task :metafacture-biblio:signMavenArtifactsPublication FAILED
62.96 [Incubating] Problems report is available at: file:///home/playground/metafacture-core/build/reports/problems/problems-report.html
63.06 
63.06 FAILURE: Build failed with an exception.
63.06 
63.06 * What went wrong:
63.06 Execution failed for task ':metafacture-biblio:signMavenArtifactsPublication'.
63.06 > Cannot perform signing task ':metafacture-biblio:signMavenArtifactsPublication' because it has no configured signatory

Full log:

sol@quaoar3:~/git/metafacture-playground$ docker compose build --no-cache
WARN[0000] /home/sol/git/metafacture-playground/docker-compose.yml: `version` is obsolete 
[+] Building 158.5s (13/22)                                                                                                                                                                  docker:default
 => [app internal] load build definition from Dockerfile.prod                                                                                                                                          0.1s
 => => transferring dockerfile: 2.00kB                                                                                                                                                                 0.0s
 => [app internal] load metadata for docker.io/adoptopenjdk/openjdk11:debian                                                                                                                           0.6s
 => [app internal] load .dockerignore                                                                                                                                                                  0.1s
 => => transferring context: 83B                                                                                                                                                                       0.0s
 => [app internal] load build context                                                                                                                                                                  0.4s
 => => transferring context: 476.69kB                                                                                                                                                                  0.3s
 => CACHED [app  1/18] FROM docker.io/adoptopenjdk/openjdk11:debian@sha256:5f6e6be3441272109da4e41c6096c230b5cd83a74b75f631b488e6ea66b0ec3b                                                            0.0s
 => [app  2/18] RUN curl -sL https://deb.nodesource.com/setup_18.x | bash                                                                                                                             20.4s
 => [app  3/18] RUN apt-get update && apt-get install -y --no-install-recommends     software-properties-common     wget     gnupg     leiningen     git     vim     nodejs     &&     apt clean &&   63.1s 
 => [app  4/18] RUN groupadd --gid 1000 playground     && useradd --uid 1000 --gid 1000 -m playground                                                                                                  1.6s 
 => [app  5/18] WORKDIR /home/playground/metafacture-core                                                                                                                                              0.7s 
 => [app  6/18] RUN git clone https://github.com/metafacture/metafacture-core.git .                                                                                                                    4.2s 
 => [app  7/18] RUN git checkout metafacture-core-6.2.0-rc1                                                                                                                                            1.5s 
 => [app  8/18] RUN git tag -d metafacture-core-6.2.0-rc1 # workaround um nicht ein release build zu installieren, das gesigned sein muss (sign fehlt aber)                                            1.3s 
 => ERROR [app  9/18] RUN ./gradlew install                                                                                                                                                           64.5s 
------                                                                                                                                                                                                      
 > [app  9/18] RUN ./gradlew install:                                                                                                                                                                       
1.192 Downloading https://services.gradle.org/distributions/gradle-8.11.1-bin.zip                                                                                                                           
2.874 .............10%.............20%.............30%.............40%.............50%.............60%.............70%.............80%.............90%.............100%                                     
10.98                                                                                                                                                                                                       
10.98 Welcome to Gradle 8.11.1!                                                                                                                                                                             
10.98 
10.98 Here are the highlights of this release:
10.98  - Parallel load and store for Configuration Cache
10.98  - Java compilation errors at the end of the build output
10.99  - Consolidated report for warnings and deprecations
10.99 
10.99 For more details see https://docs.gradle.org/8.11.1/release-notes.html
10.99 
11.36 Starting a Gradle Daemon (subsequent builds will be faster)
39.57 
39.58 > Configure project :
39.58 Found annotated tag metafacture-core-6.2.0
39.58 SCM tag found. Making a release build
39.58 Version is 6.2.0
54.16 
54.16 > Task :metafacture-commons:compileJava
54.66 > Task :metafacture-framework:compileJava
55.46 > Task :metafacture-flowcontrol:compileJava
58.16 > Task :metafacture-biblio:compileJava
58.16 > Task :metafacture-biblio:processResources
58.17 > Task :metafacture-biblio:classes
58.26 > Task :metafacture-biblio:jar
58.36 > Task :metafacture-biblio:generateMetadataFileForMavenArtifactsPublication
58.36 > Task :metafacture-biblio:generatePomFileForMavenArtifactsPublication
62.66 > Task :metafacture-biblio:javadoc
62.86 > Task :metafacture-biblio:javadocJar
62.86 > Task :metafacture-biblio:sourceJar
62.86 > Task :metafacture-biblio:signMavenArtifactsPublication FAILED
62.96 [Incubating] Problems report is available at: file:///home/playground/metafacture-core/build/reports/problems/problems-report.html
63.06 
63.06 FAILURE: Build failed with an exception.
63.06 
63.06 * What went wrong:
63.06 Execution failed for task ':metafacture-biblio:signMavenArtifactsPublication'.
63.06 > Cannot perform signing task ':metafacture-biblio:signMavenArtifactsPublication' because it has no configured signatory
63.07 
63.07 * Try:
63.07 > Run with --stacktrace option to get the stack trace.
63.07 > Run with --info or --debug option to get more log output.
63.07 > Run with --scan to get full insights.
63.07 > Get more help at https://help.gradle.org.
63.07 
63.07 Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
63.07 
63.07 You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
63.07 
63.07 For more on this, please refer to https://docs.gradle.org/8.11.1/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
63.07 
63.07 BUILD FAILED in 1m 2s
63.07 12 actionable tasks: 12 executed
------
failed to solve: process "/bin/sh -c ./gradlew install" did not complete successfully: exit code: 1

@blackwinter
Copy link
Member

You probably want to adjust your workaround:

=> [app 8/18] RUN git tag -d metafacture-core-6.2.0-rc1 # workaround um nicht ein release build zu installieren, das gesigned sein muss (sign fehlt aber) 1.3s

It's trying to build a release version which includes signing:

39.58 Found annotated tag metafacture-core-6.2.0
39.58 SCM tag found. Making a release build
39.58 Version is 6.2.0

@Phu2
Copy link

Phu2 commented Dec 20, 2024

https://test.metafacture.org/playground/ now runs with metafix 1.2.0-rc1. Thanks for your help, @fsteeg !
Please have a look, @TobiasNx .

@TobiasNx
Copy link
Collaborator

looks good!

@fsteeg fsteeg unassigned Phu2 and TobiasNx Dec 20, 2024
@fsteeg
Copy link
Member

fsteeg commented Dec 20, 2024

@blackwinter
Copy link
Member

@dr0i referred to the wiki page in the issue description above.

@fsteeg
Copy link
Member

fsteeg commented Dec 20, 2024

Released, closing, see: https://github.com/metafacture/metafacture-fix/releases

Pushed to publish branch and 1.2.0 tag, but nothing to master since we froze the repo.

@fsteeg fsteeg closed this as completed Dec 20, 2024
@github-project-automation github-project-automation bot moved this from Ready to Done in Metafacture Dec 20, 2024
@blackwinter
Copy link
Member

Thanks! What's your opinion on adding a notice to the release notes?

Pushed to publish branch and 1.2.0 tag, but nothing to master since we froze the repo.

You can still do so, we just won't carry it over (version number and tag would be dropped anyway).

@fsteeg
Copy link
Member

fsteeg commented Dec 20, 2024

Thanks! What's your opinion on adding a notice to the release notes?

Right now it's the latest version, so I don't think it's needed now. Maybe we could add a note after the first release in core, pointing to the new release?

You can still do so, we just won't carry it over (version number and tag would be dropped anyway).

Ah, right, pushed to master.

@blackwinter
Copy link
Member

Maybe we could add a note after the first release in core, pointing to the new release?

You mean retroactively adding it to the 1.2.0 release? Sure, that's also a possibility. My rationale was that anyone looking at the release now will know where to look for new releases in the future; instead of someday wondering about the absence of new releases and then finding the notice after the fact.

@fsteeg
Copy link
Member

fsteeg commented Dec 20, 2024

Added the note: https://github.com/metafacture/metafacture-fix/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants