Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karma-ievms package version is broken #46

Closed
ipeychev opened this issue Mar 7, 2017 · 2 comments
Closed

karma-ievms package version is broken #46

ipeychev opened this issue Mar 7, 2017 · 2 comments

Comments

@ipeychev
Copy link
Contributor

ipeychev commented Mar 7, 2017

The karma-ievms used in this repository is broken. There is an issue, opened long time ago and still not merged. This error happens on each local machine when we run the tests on IE. Someone created a fix here and in order to fix the issue for us, we may do one of these:

  1. Change our package.json and make karma-ievms to look like this: "karma-ievms": "git+https://github.com/niksy/karma-ievms.git#browser-decorator" instead "karma-ievms": "^0.1.0",.
  2. If pointing to an external third party repository is unacceptable, we may fork this repository and apply the same fix. Then we would replace the value of karma-ievms in package.json with our forked version.

Please let me know which of these (or some other option) are OK for you.

/cc @eduardolundgren

@eduardolundgren
Copy link
Contributor

Option (1) sounds good for me.

@ipeychev
Copy link
Contributor Author

Great, PR is coming!

ipeychev added a commit to ipeychev/gulp-metal that referenced this issue Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants