-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remaining proposed syl renames (group 2) #4504
Comments
My remark would be that most, if not all of these renames increase the length of the theorem name. For example from But clearly here we want to be more expressing, and there is no way to carry more information in the name while being as short as a numbering, so this is probably the lesser of two evils. |
It is misleading to put these two things in comparison: the shortenings seek to reduce the number of proof steps: that translates into byte reduction, but that is only a byproduct, not the objective. |
These had their roots in a proposal by Norm which has received some refinement, discussion, and action since.
The proposed changes are listed in
changes-set.txt
and the division into groups is from #4332 (comment) . Group 1 from that comment is done, this issue is about group 2, and #4505 is for groups 3 and 4.The proposed renames in group 2 are:
and I grouped them this way because the new names seem fairly obvious to me based on the patterns we have established in the past.
Feel free to make suggestions for alternate names or any of these that aren't a good idea, but unless we hear otherwise, I think we can all assume these are a good idea and we're ready to start making pull requests.
Some guidelines based on our recent experience:
New usage is discouraged
(that just makes merge conflicts in thediscouraged
file more likely, and doesn't seem to have significant benefits for this purpose).The text was updated successfully, but these errors were encountered: