User input "gpu"
is inplaced renamed to "cuda"
#326
Labels
Good first issue
Good for newcomers
Infrastructure: Miscellaneous
General infrastructure issues
Priority: Medium
Important issues to address after high priority.
If one picks a device as
gpu
,multi-gpu
we change this input inplace to"cuda"
,"mps"
or"multi-cuda"
as inhttps://github.com/lab-cosmo/metatrain/blob/96f2c74f0a371845497604d7d594d1db6b273a1d/src/metatrain/utils/devices.py#L54-L58
and
https://github.com/lab-cosmo/metatrain/blob/96f2c74f0a371845497604d7d594d1db6b273a1d/src/metatrain/utils/devices.py#L68-L69
I think this is not ideal because probable later error raises will confront the user with a device
"cuda"
or"multi-cuda"
which he did not specify in the input. Maybe it is better to store an internal name likeresolved_device
and not override the user input.The linked code above will should be changed to
and
The text was updated successfully, but these errors were encountered: