Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some parameters might not work if given as integers #414

Open
frostedoyster opened this issue Dec 6, 2024 · 2 comments · May be fixed by #419
Open

Some parameters might not work if given as integers #414

frostedoyster opened this issue Dec 6, 2024 · 2 comments · May be fixed by #419
Assignees
Labels
Bug Something isn't working Priority: Medium Important issues to address after high priority.

Comments

@frostedoyster
Copy link
Collaborator

We recently found out that e.g. in PET setting a cutoff of 5 doesn't work, as it should be 5.0

@DavideTisi @abmazitov

@frostedoyster frostedoyster added Bug Something isn't working Priority: Medium Important issues to address after high priority. labels Dec 6, 2024
@Luthaf
Copy link
Member

Luthaf commented Dec 6, 2024

So either we can try to enforce the use of float by the user (by changing the validation done though JSON schema); or we can normalize types to float in the model. I feel like the first case is less convenient, users have to change 5 to 5.0 in the input for seemingly no reason; so I would normalize inside the model instead, i.e. self.cutoff = float(hypers["CUTOFF"]) or even just hypers["CUTOFF"] = float(hypers["CUTOFF"])

@DavideTisi
Copy link
Contributor

I agree that the second solution of "casting" CUTOFF to float seems the most reasonable thing to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Priority: Medium Important issues to address after high priority.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants