You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So either we can try to enforce the use of float by the user (by changing the validation done though JSON schema); or we can normalize types to float in the model. I feel like the first case is less convenient, users have to change 5 to 5.0 in the input for seemingly no reason; so I would normalize inside the model instead, i.e. self.cutoff = float(hypers["CUTOFF"]) or even just hypers["CUTOFF"] = float(hypers["CUTOFF"])
We recently found out that e.g. in PET setting a cutoff of
5
doesn't work, as it should be5.0
@DavideTisi @abmazitov
The text was updated successfully, but these errors were encountered: