Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zooming options #30

Closed
wlach opened this issue Jun 29, 2018 · 2 comments
Closed

Add zooming options #30

wlach opened this issue Jun 29, 2018 · 2 comments

Comments

@wlach
Copy link
Collaborator

wlach commented Jun 29, 2018

In order for projects like missioncontrol to be able to use the new brushing/zooming functionality, we'll need to add the new brushing/zooming properties to the list of supported properties by this package:

https://github.com/metricsgraphics/react-metrics-graphics/blob/master/README.md#properties
https://github.com/metricsgraphics/react-metrics-graphics/blob/master/src/components/MetricsGraphics.jsx#L6

@cnwangjie is this something you might want to take care of? Should be a relatively straightforward task. :)

(it would be nice if we didn't have to do this, see #23 -- but I don't think it's worth blocking this functionality on that larger solution being implemented)

@cnwangjie
Copy link
Contributor

@wlach It's my pleasure to do it. I've submitted a PR to add the options for zooming.

As #23, currently we must modify the array here whenever the available options change. I think we can avoid a repeat. Maybe we can export a list of available options in metrics-graphics. It is already an object. We just need to export it simply and we can easily pack it into a single component for React or Vue.

@wlach
Copy link
Collaborator Author

wlach commented Jun 30, 2018

Fixed with #32, thank you @cnwangjie

I filed metricsgraphics/metrics-graphics#875 as a followup to export the list of options from metrics graphics itself.

@wlach wlach closed this as completed Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants