From 7c628cca9b6f4afb00c5180b263240f7d36a95f9 Mon Sep 17 00:00:00 2001 From: Michael Bull Date: Tue, 5 Mar 2024 23:51:02 +0000 Subject: [PATCH] Mark objects as data objects in tests --- .../example/model/domain/DomainMessage.kt | 28 +++++++++---------- .../result/example/model/domain/Event.kt | 10 +++---- .../binding/AsyncSuspendableBindingTest.kt | 4 +-- .../com/github/michaelbull/result/GetTest.kt | 6 ++-- 4 files changed, 24 insertions(+), 24 deletions(-) diff --git a/example/src/main/kotlin/com/github/michaelbull/result/example/model/domain/DomainMessage.kt b/example/src/main/kotlin/com/github/michaelbull/result/example/model/domain/DomainMessage.kt index 832b48c..e193c0a 100644 --- a/example/src/main/kotlin/com/github/michaelbull/result/example/model/domain/DomainMessage.kt +++ b/example/src/main/kotlin/com/github/michaelbull/result/example/model/domain/DomainMessage.kt @@ -3,29 +3,29 @@ package com.github.michaelbull.result.example.model.domain /** * All possible things that can happen in the use-cases */ -sealed class DomainMessage +sealed interface DomainMessage /* validation errors */ -object CustomerRequired : DomainMessage() -object CustomerIdMustBePositive : DomainMessage() +data object CustomerRequired : DomainMessage +data object CustomerIdMustBePositive : DomainMessage -object FirstNameRequired : DomainMessage() -object FirstNameTooLong : DomainMessage() +data object FirstNameRequired : DomainMessage +data object FirstNameTooLong : DomainMessage -object LastNameRequired : DomainMessage() -object LastNameTooLong : DomainMessage() +data object LastNameRequired : DomainMessage +data object LastNameTooLong : DomainMessage -object EmailRequired : DomainMessage() -object EmailTooLong : DomainMessage() -object EmailInvalid : DomainMessage() +data object EmailRequired : DomainMessage +data object EmailTooLong : DomainMessage +data object EmailInvalid : DomainMessage /* exposed errors */ -object CustomerNotFound : DomainMessage() +data object CustomerNotFound : DomainMessage /* internal errors */ -object SqlCustomerInvalid : DomainMessage() -object DatabaseTimeout : DomainMessage() -class DatabaseError(val reason: String?) : DomainMessage() +data object SqlCustomerInvalid : DomainMessage +data object DatabaseTimeout : DomainMessage +data class DatabaseError(val reason: String?) : DomainMessage diff --git a/example/src/main/kotlin/com/github/michaelbull/result/example/model/domain/Event.kt b/example/src/main/kotlin/com/github/michaelbull/result/example/model/domain/Event.kt index 56527fd..dc7b130 100644 --- a/example/src/main/kotlin/com/github/michaelbull/result/example/model/domain/Event.kt +++ b/example/src/main/kotlin/com/github/michaelbull/result/example/model/domain/Event.kt @@ -1,8 +1,8 @@ package com.github.michaelbull.result.example.model.domain -sealed class Event +sealed interface Event -object Created : Event() -class FirstNameChanged(val old: String, val new: String) : Event() -class LastNameChanged(val old: String, val new: String) : Event() -class EmailAddressChanged(val old: String, val new: String) : Event() +data object Created : Event +data class FirstNameChanged(val old: String, val new: String) : Event +data class LastNameChanged(val old: String, val new: String) : Event +data class EmailAddressChanged(val old: String, val new: String) : Event diff --git a/kotlin-result-coroutines/src/jvmTest/kotlin/com/github/michaelbull/result/coroutines/binding/AsyncSuspendableBindingTest.kt b/kotlin-result-coroutines/src/jvmTest/kotlin/com/github/michaelbull/result/coroutines/binding/AsyncSuspendableBindingTest.kt index be37022..d04a356 100644 --- a/kotlin-result-coroutines/src/jvmTest/kotlin/com/github/michaelbull/result/coroutines/binding/AsyncSuspendableBindingTest.kt +++ b/kotlin-result-coroutines/src/jvmTest/kotlin/com/github/michaelbull/result/coroutines/binding/AsyncSuspendableBindingTest.kt @@ -18,8 +18,8 @@ import kotlin.test.assertTrue class AsyncSuspendableBindingTest { private sealed class BindingError { - object BindingErrorA : BindingError() - object BindingErrorB : BindingError() + data object BindingErrorA : BindingError() + data object BindingErrorB : BindingError() } @Test diff --git a/kotlin-result/src/commonTest/kotlin/com/github/michaelbull/result/GetTest.kt b/kotlin-result/src/commonTest/kotlin/com/github/michaelbull/result/GetTest.kt index e6d20b4..c23fc9c 100644 --- a/kotlin-result/src/commonTest/kotlin/com/github/michaelbull/result/GetTest.kt +++ b/kotlin-result/src/commonTest/kotlin/com/github/michaelbull/result/GetTest.kt @@ -148,9 +148,9 @@ class GetTest { } class Merge { - interface Direction - object Left : Direction - object Right : Direction + sealed interface Direction + data object Left : Direction + data object Right : Direction @Test fun returnsValueIfOk() {