Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 invisible callback options #67

Closed
thomasonk opened this issue Mar 19, 2024 · 1 comment · Fixed by #69
Closed

v2 invisible callback options #67

thomasonk opened this issue Mar 19, 2024 · 1 comment · Fixed by #69

Comments

@thomasonk
Copy link

thomasonk commented Mar 19, 2024

Can the callback options for error and expired be included for v2 invisible? They appear to only be included for V2. They appear to be valid for v2 invisible as well as v2 checkbox.

From RecaptchaTagHelper.cs
ReCaptchaVersion.V2Invisible => ReCaptchaGenerator.ReCaptchaV2Invisible(settings.RecaptchaBaseUrl, settings.SiteKey, Text, ClassName, Language, Callback, Badge),
ReCaptchaVersion.V3 => ReCaptchaGenerator.ReCaptchaV3(settings.RecaptchaBaseUrl, settings.SiteKey, Action, Language, Callback, ReCaptchaGenerator.GenerateId(ViewContext), Nonce),
_ => ReCaptchaGenerator.ReCaptchaV2(settings.RecaptchaBaseUrl, settings.SiteKey, Size, Theme, Language, Callback, ErrorCallback, ExpiredCallback, AutoTheme, Nonce),

@sleeuwen
Copy link
Collaborator

Hi @thomasonk ,

Sorry for the late response, I didn't get a notification of this issue. I double checked and the callbacks are indeed valid for the V2 invisible version. I've created a PR to add this: #69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants