Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include vs includes? #18

Open
jimsheldon opened this issue Oct 14, 2019 · 1 comment
Open

include vs includes? #18

jimsheldon opened this issue Oct 14, 2019 · 1 comment

Comments

@jimsheldon
Copy link

Hello!

We are very interested in using this plugin, but we are hoping to "future proof" it as much as possible.

Currently the required syntax is:

   when:
      changeset:
        includes: [ **/**.js, **/**.css, **/**.html ]

and

trigger:
  changeset:
    includes: [ **/**.go ]

All other drone syntax seems to use include rather than includes. Would you consider a new version of this plugin with a breaking change that switches to include to match drone's official syntax? Or maybe there is a way this plugin could support both include and includes?

@microadam
Copy link
Owner

Hi @jimsheldon more than happy for it to support both :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants