-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide an option to supply common tags for registries. #3744
Comments
Well, this issue is subtly different from the existing "commonTags" method which adds the commonTags to all the meters which are processed once every step interval. |
Why won't a |
Because it is not so efficient to do it every time we interact with the meter. A 1x1 example is OpenTelemetry's Resource, where unique information can be store once and re-used multiple times. If we try to do this in a meterfilter, every single time a meter needs to be recorded we have to run through the filter and add tags and them record the value on it. E.g: Let's I have a service fooserv and I need this info to be added to all the meters. If I add a meter filter, every time I want to record metric for a HTTP request, initially i would create a meter with information like path, status and etc. When I call register on the meter, the filters get executed and it tries to add a new tag service=fooserv. Since Meter.Id is immutable this creates a new object and registers it. This is the additional hop I am talking about. Alternatively, if We can say to the registry that service=fooserv is needed on all the metric, it can add that information during export time alone to the actual protocol it talks to. |
If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed. |
@marcingrzejszczak How can we prevent an auto close on this issue? |
If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed. |
Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open. |
This seems to have been closed unintentionally by the bot. |
We need to look into why the bot ignores comments, it seems it closes every issue that has the |
@lenin-jaganathan Do you think this issue is similar/related to these two? |
Yeah more like #5112. I will close this. |
Please describe the feature request.
This thought arrived during a discussion on #2818. The thought process is that MeterRegistries can take common tags static to a JVM (like app_name, host_name, region, manifest, and whatnot) and use that to append as metadata while sending metrics (if the back-end supports that) or at least use those common tags to get translated to corresponding systems
tag
equivalent once and use it for every publish.Rationale
The text was updated successfully, but these errors were encountered: