Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: consider exporting our selectors from #2643

Open
compulim opened this issue Nov 29, 2019 · 0 comments
Open

core: consider exporting our selectors from #2643

compulim opened this issue Nov 29, 2019 · 0 comments
Labels
backlog Out of scope for the current iteration but it will be evaluated in a future release. feature-request Azure report label

Comments

@compulim
Copy link
Contributor

In BasicTranscript.js, we did not use core's selector for selecting speaking activity. We should consider exporting those selectors.

// TODO: [P2] We should use core/definitions/speakingActivity for this predicate instead
@compulim compulim added Enhancement customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. and removed Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. labels Nov 29, 2019
@compulim compulim mentioned this issue Nov 29, 2019
Merged
1 task
@corinagum corinagum added backlog Out of scope for the current iteration but it will be evaluated in a future release. and removed Pending labels Jan 15, 2020
@corinagum corinagum added feature-request Azure report label and removed Enhancement labels Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Out of scope for the current iteration but it will be evaluated in a future release. feature-request Azure report label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@compulim @corinagum