From 63aacef2742bbcd0148794ff2060c0e77a3ffef0 Mon Sep 17 00:00:00 2001 From: James Lamb Date: Tue, 9 Jan 2024 22:02:31 -0600 Subject: [PATCH 1/6] [python-package] upgrade to scikit-build-core 0.7.0 --- python-package/pyproject.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python-package/pyproject.toml b/python-package/pyproject.toml index d5586aa3857d..02a9689b2158 100644 --- a/python-package/pyproject.toml +++ b/python-package/pyproject.toml @@ -57,7 +57,7 @@ changelog = "https://github.com/microsoft/LightGBM/releases" # start:build-system [build-system] -requires = ["scikit-build-core>=0.4.4"] +requires = ["scikit-build-core>=0.7.0"] build-backend = "scikit_build_core.build" # based on https://github.com/scikit-build/scikit-build-core#configuration @@ -76,7 +76,7 @@ sdist.reproducible = true wheel.py-api = "py3" experimental = false strict-config = true -minimum-version = "0.4.4" +minimum-version = "0.7.0" # end:build-system From 8c6a8e345a7b7430b74ccc1ec2cfff57755390c2 Mon Sep 17 00:00:00 2001 From: James Lamb Date: Tue, 9 Jan 2024 22:15:22 -0600 Subject: [PATCH 2/6] 0.7.1 --- python-package/pyproject.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python-package/pyproject.toml b/python-package/pyproject.toml index 02a9689b2158..80cd95d86908 100644 --- a/python-package/pyproject.toml +++ b/python-package/pyproject.toml @@ -57,7 +57,7 @@ changelog = "https://github.com/microsoft/LightGBM/releases" # start:build-system [build-system] -requires = ["scikit-build-core>=0.7.0"] +requires = ["scikit-build-core>=0.7.1"] build-backend = "scikit_build_core.build" # based on https://github.com/scikit-build/scikit-build-core#configuration @@ -76,7 +76,7 @@ sdist.reproducible = true wheel.py-api = "py3" experimental = false strict-config = true -minimum-version = "0.7.0" +minimum-version = "0.7.1" # end:build-system From fb8e4e122498eed5bbf1a2b25a3d9fb36f1e72fe Mon Sep 17 00:00:00 2001 From: James Lamb Date: Sat, 3 Feb 2024 18:12:31 -0600 Subject: [PATCH 3/6] updatte version config --- python-package/pyproject.toml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/python-package/pyproject.toml b/python-package/pyproject.toml index 224c46e77a12..70cd36158489 100644 --- a/python-package/pyproject.toml +++ b/python-package/pyproject.toml @@ -57,26 +57,27 @@ changelog = "https://github.com/microsoft/LightGBM/releases" # start:build-system [build-system] -requires = ["scikit-build-core>=0.7.1"] +requires = ["scikit-build-core>=0.8.0"] build-backend = "scikit_build_core.build" # based on https://github.com/scikit-build/scikit-build-core#configuration [tool.scikit-build] -cmake.minimum-version = "3.18" -ninja.minimum-version = "1.11" +cmake.version = ">=3.18" +ninja.version = ">=1.11" ninja.make-fallback = true cmake.args = [ "-D__BUILD_FOR_PYTHON:BOOL=ON" ] cmake.verbose = false cmake.build-type = "Release" +install.strip = true logging.level = "INFO" sdist.reproducible = true wheel.py-api = "py3" experimental = false strict-config = true -minimum-version = "0.7.1" +minimum-version = "0.8.0" # end:build-system From 3d194c8edfb3086a9eb8c53c571936521f7e37fe Mon Sep 17 00:00:00 2001 From: James Lamb Date: Fri, 19 Apr 2024 23:39:23 -0500 Subject: [PATCH 4/6] newer scikit-built-core --- python-package/pyproject.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python-package/pyproject.toml b/python-package/pyproject.toml index b3a13fa04dcc..ef56e4c8b5f6 100644 --- a/python-package/pyproject.toml +++ b/python-package/pyproject.toml @@ -57,7 +57,7 @@ changelog = "https://github.com/microsoft/LightGBM/releases" # start:build-system [build-system] -requires = ["scikit-build-core>=0.8.0"] +requires = ["scikit-build-core>=0.9.1"] build-backend = "scikit_build_core.build" # based on https://github.com/scikit-build/scikit-build-core#configuration @@ -77,7 +77,7 @@ sdist.reproducible = true wheel.py-api = "py3" experimental = false strict-config = true -minimum-version = "0.8.0" +minimum-version = "0.9.1" # end:build-system From 754b5c909540cc0ceea19ff7bea1fb3564096b0b Mon Sep 17 00:00:00 2001 From: James Lamb Date: Sun, 5 May 2024 18:51:57 -0500 Subject: [PATCH 5/6] 0.9.3 --- python-package/pyproject.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python-package/pyproject.toml b/python-package/pyproject.toml index ef56e4c8b5f6..cd9058dc0c96 100644 --- a/python-package/pyproject.toml +++ b/python-package/pyproject.toml @@ -57,7 +57,7 @@ changelog = "https://github.com/microsoft/LightGBM/releases" # start:build-system [build-system] -requires = ["scikit-build-core>=0.9.1"] +requires = ["scikit-build-core>=0.9.3"] build-backend = "scikit_build_core.build" # based on https://github.com/scikit-build/scikit-build-core#configuration @@ -77,7 +77,7 @@ sdist.reproducible = true wheel.py-api = "py3" experimental = false strict-config = true -minimum-version = "0.9.1" +minimum-version = "0.9.3" # end:build-system From a20f27f5a77b97fd14173f8f9f11c74129150524 Mon Sep 17 00:00:00 2001 From: James Lamb Date: Tue, 7 May 2024 23:57:27 -0500 Subject: [PATCH 6/6] opt out of stripping binaries --- python-package/pyproject.toml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/python-package/pyproject.toml b/python-package/pyproject.toml index cd9058dc0c96..387fbd2e407a 100644 --- a/python-package/pyproject.toml +++ b/python-package/pyproject.toml @@ -71,7 +71,10 @@ cmake.args = [ ] cmake.verbose = false cmake.build-type = "Release" -install.strip = true +cmake.targets = ["_lightgbm"] +# stripping binaries should be turned back on once this is fixed: +# https://github.com/jameslamb/pydistcheck/issues/235 +install.strip = false logging.level = "INFO" sdist.reproducible = true wheel.py-api = "py3"