Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In -target-select {remoteMode} {destination}, the GDB remoteMode should also be able to be supplied by user. #1410

Open
xiahualiu opened this issue Jul 10, 2023 · 0 comments

Comments

@xiahualiu
Copy link

if (!string.IsNullOrWhiteSpace(destination))
{
string remoteMode = useExtendedRemote ? "extended-remote" : "remote";
commands.Add(new LaunchCommand($"-target-select {remoteMode} {destination}", string.Format(CultureInfo.CurrentCulture, ResourceStrings.ConnectingMessage, destination)));
}

As you can see, the remoteMode can only be chosen from extended-remote or remote. After checking the older commits I believe the extended-remote was previously added to give support for the OpenOCD debugging server.

However, there are many other remote targets out there. For example, QNX OS uses qnx as the GDB target. You can list all available targets using help target in a GDB console.

I think making the {remoteMode} a json user-defined variable is a better idea. Since it is really up to the user what type of remote target gdb is going to attach to, and should not be limited by the fixed options provided by VS Code.

Thanks,
Xiahua

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant