Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] need to document that if the protos change you have to update poe gen-proto #3812

Closed
rysweet opened this issue Oct 16, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation size-small takes 1-2 days
Milestone

Comments

@rysweet
Copy link
Collaborator

rysweet commented Oct 16, 2024

What feature would you like to be added?

if you change the global .proto files you have to run

cd python
python -m pip instal uv
uv sync --all-extras
source .venv/bin/activate
poe gén-proto

Why is this needed?

perhaps we could add this to the build if the protos have changed?

@jackgerrits
Copy link
Member

This is checked in CI to ensure it remains in sync:

check-proto-changes-python:

@jackgerrits jackgerrits added this to the 0.4 milestone Oct 22, 2024
@jackgerrits jackgerrits added the documentation Improvements or additions to documentation label Oct 22, 2024
@fniedtner fniedtner removed the feature label Oct 24, 2024
@jackgerrits jackgerrits added the size-small takes 1-2 days label Oct 24, 2024
@jackgerrits
Copy link
Member

CI checks this, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size-small takes 1-2 days
Projects
None yet
Development

No branches or pull requests

3 participants