From e13cd4c6915191237bc4bb229ead8cd7c330bced Mon Sep 17 00:00:00 2001 From: Ryan Campbell Date: Tue, 30 Jul 2024 23:28:45 +0000 Subject: [PATCH 1/4] adjusting timings --- chart/templates/_dapr.tpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chart/templates/_dapr.tpl b/chart/templates/_dapr.tpl index e5e4dfe..d5b10ba 100644 --- a/chart/templates/_dapr.tpl +++ b/chart/templates/_dapr.tpl @@ -9,7 +9,7 @@ dapr.io/log-level: {{ $globalValues.dapr.logLevel | quote }} dapr.io/enable-api-logging: "true" dapr.io/enable-app-health-check: "true" dapr.io/app-health-probe-interval: "5" -dapr.io/app-health-probe-timeout: "10000" +dapr.io/app-health-probe-timeout: "3000" dapr.io/app-health-threshold: "50" {{- if $serviceValues.debugShim }} dapr.io/sidecar-liveness-probe-delay-seconds: "2" From 746eeaddb6106038c4d77c7841d9fd4a2fa22385 Mon Sep 17 00:00:00 2001 From: Ryan Campbell Date: Tue, 30 Jul 2024 23:31:18 +0000 Subject: [PATCH 2/4] updating threshold to 100 to never stop --- chart/templates/_dapr.tpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chart/templates/_dapr.tpl b/chart/templates/_dapr.tpl index d5b10ba..024dc6c 100644 --- a/chart/templates/_dapr.tpl +++ b/chart/templates/_dapr.tpl @@ -10,7 +10,7 @@ dapr.io/enable-api-logging: "true" dapr.io/enable-app-health-check: "true" dapr.io/app-health-probe-interval: "5" dapr.io/app-health-probe-timeout: "3000" -dapr.io/app-health-threshold: "50" +dapr.io/app-health-threshold: "100" {{- if $serviceValues.debugShim }} dapr.io/sidecar-liveness-probe-delay-seconds: "2" dapr.io/sidecar-liveness-probe-period-seconds: "2" From 3fbec47662ff78970f9c3f44a17eebda0419380f Mon Sep 17 00:00:00 2001 From: Ryan Campbell Date: Tue, 30 Jul 2024 23:44:43 +0000 Subject: [PATCH 3/4] updating to disable app health check on services (temporarily) --- chart/templates/_dapr.tpl | 4 +++- chart/values.yaml | 8 ++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/chart/templates/_dapr.tpl b/chart/templates/_dapr.tpl index 024dc6c..7ebd943 100644 --- a/chart/templates/_dapr.tpl +++ b/chart/templates/_dapr.tpl @@ -7,13 +7,15 @@ dapr.io/app-protocol: "grpc" dapr.io/app-port: "50051" dapr.io/log-level: {{ $globalValues.dapr.logLevel | quote }} dapr.io/enable-api-logging: "true" -dapr.io/enable-app-health-check: "true" dapr.io/app-health-probe-interval: "5" dapr.io/app-health-probe-timeout: "3000" dapr.io/app-health-threshold: "100" {{- if $serviceValues.debugShim }} +dapr.io/enable-app-health-check: "true" dapr.io/sidecar-liveness-probe-delay-seconds: "2" dapr.io/sidecar-liveness-probe-period-seconds: "2" dapr.io/sidecar-liveness-probe-threshold: "9999" +{{- else }} +dapr.io/enable-app-health-check: {{ $serviceValues.appHealthCheck | ternary "true" "false" }} {{- end }} {{- end }} \ No newline at end of file diff --git a/chart/values.yaml b/chart/values.yaml index 836c7c5..aac1878 100644 --- a/chart/values.yaml +++ b/chart/values.yaml @@ -179,6 +179,7 @@ services: appConfig: - name: messageResponseTimeoutMS value: 15000 + appHealthCheck: false appName: platform-mts buildService: dockerFile: Dockerfile.buildsvc.app @@ -198,6 +199,7 @@ services: workingDir: /workspaces/platform-mts deployment: appName: platform-deployment + appHealthCheck: false buildService: dockerFile: Dockerfile.buildsvc.app contextDir: build/dotnet @@ -254,6 +256,7 @@ services: - name: enableRoutingToMTS value: true appName: vth + appHealthCheck: false buildService: dockerFile: Dockerfile.buildsvc.app contextDir: build/dotnet @@ -278,6 +281,7 @@ services: - name: messageResponseTimeoutMS value: 15000 appName: hostsvc-sensor + appHealthCheck: false buildService: dockerFile: Dockerfile.buildsvc.app contextDir: build/dotnet @@ -305,6 +309,7 @@ services: - name: allowLinksToDeploymentSvc value: false appName: hostsvc-link + appHealthCheck: false buildService: dockerFile: Dockerfile.buildsvc.app contextDir: build/dotnet @@ -332,6 +337,7 @@ services: - name: writeTelemetryToLog value: true appName: hostsvc-logging + appHealthCheck: false buildService: dockerFile: Dockerfile.buildsvc.app contextDir: build/dotnet @@ -350,6 +356,7 @@ services: workingDir: /workspaces/hostsvc-logging position: appName: hostsvc-position + appHealthCheck: false buildService: dockerFile: Dockerfile.buildsvc.app contextDir: build/dotnet @@ -399,6 +406,7 @@ services: serviceAccount: enabled: false appContext: null + appHealthCheck: false appName: payloadappTemplate appGroup: payloadappGroup correlationId: null From 19f58402fceb1a50de1f1f839c4b8325b61fe6d7 Mon Sep 17 00:00:00 2001 From: Ryan Campbell Date: Tue, 30 Jul 2024 23:50:26 +0000 Subject: [PATCH 4/4] change value to true false --- chart/templates/_dapr.tpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chart/templates/_dapr.tpl b/chart/templates/_dapr.tpl index 7ebd943..5e04cac 100644 --- a/chart/templates/_dapr.tpl +++ b/chart/templates/_dapr.tpl @@ -16,6 +16,6 @@ dapr.io/sidecar-liveness-probe-delay-seconds: "2" dapr.io/sidecar-liveness-probe-period-seconds: "2" dapr.io/sidecar-liveness-probe-threshold: "9999" {{- else }} -dapr.io/enable-app-health-check: {{ $serviceValues.appHealthCheck | ternary "true" "false" }} +dapr.io/enable-app-health-check: {{ $serviceValues.appHealthCheck | quote }} {{- end }} {{- end }} \ No newline at end of file