Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Typescript definition and documentation for sync method does not align with code #649

Open
stevebering opened this issue Sep 9, 2020 · 0 comments

Comments

@stevebering
Copy link

Thanks so much for filing an issue or feature request! Please fill out the following (wherever relevant):

Description

The source code for the sync method takes 4 arguments (syncCallback, syncOptions, downloadProgress and syncErrback), but the documentation and the typescript definition file only describe the first 3 arguments. This causes linting issues when transpiling the code and keeps developers from being able to correctly implement the error callback function. I expect to have the documentation and typescript definition to match the implementation of the code.

Reproduction

Source:

codePush.js:
CodePush.prototype.sync = function (syncCallback, syncOptions, downloadProgress, syncErrback)

codePush.d.ts:
sync(syncCallback?: SuccessCallback, syncOptions?: SyncOptions, downloadProgress?: SuccessCallback): void;

Additional Information

  • cordova-plugin-code-push version: 1.12.0 and above
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant