From 7b69f08b45d69a89af97937ba3c755265e681bda Mon Sep 17 00:00:00 2001 From: Alan Jowett Date: Thu, 10 Oct 2024 10:35:54 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Dave Thaler --- libs/runtime/ebpf_epoch.c | 3 ++- libs/runtime/unit/platform_unit_test.cpp | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/runtime/ebpf_epoch.c b/libs/runtime/ebpf_epoch.c index 06623315a5..8ee18a2a58 100644 --- a/libs/runtime/ebpf_epoch.c +++ b/libs/runtime/ebpf_epoch.c @@ -1182,7 +1182,8 @@ _IRQL_requires_(DISPATCH_LEVEL) static void _ebpf_epoch_deactivate_cpu(uint32_t { EBPF_LOG_ENTRY(); ebpf_assert(cpu_id == ebpf_get_current_cpu()); - // Deactivate the CPU 0 is not allowed. + + // Deactivating CPU 0 is not allowed. ebpf_assert(cpu_id != 0); ebpf_assert(ebpf_list_is_empty(&_ebpf_epoch_cpu_table[cpu_id].epoch_state_list)); ebpf_assert(ebpf_list_is_empty(&_ebpf_epoch_cpu_table[cpu_id].free_list)); diff --git a/libs/runtime/unit/platform_unit_test.cpp b/libs/runtime/unit/platform_unit_test.cpp index b8b9b7f0db..5836b29549 100644 --- a/libs/runtime/unit/platform_unit_test.cpp +++ b/libs/runtime/unit/platform_unit_test.cpp @@ -673,7 +673,6 @@ _run_epoch_test_script(const std::vector& script) test_helper.initialize(); // Add scope to ensure that epoch state is cleaned up before test_helper. { - std::vector work_item_contexts(2); std::vector epoch_states = {false, false}; std::vector work_items;